fix(loader): rename window parameter

[floyd-may]

fix(loader): rename window parameter

The parameter name of window causes problems with
code coverage tools.

Closes #3449

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[floyd-may]

CLA signing is in-progress. Real name is really, REALLY close to my username.

[petebacondarwin]

@floyd-may - I have looked at the issue in blanket: alex-seville/blanket#311. In there they imply that they will be removing this rule in version 2.0, which will mean that this will no longer be an issue.

Moreover, another comment suggests that if you reference the minified version of AngularJS then this variable is already renamed. I would imagine that this is a reasonable workaround to your problem, since you are probably only interested in code coverage of your application code, not the AngularJS codebase.

Therefore, I am going to close this PR since I don't believe that renaming this variable is a reasonable request, given that it really is the window object (most of the time :-) ).

Do please post further comments or an alternate PR/issue if you feel that there is more to discuss here.