Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

chore(jqLite): implement the detach method #5458

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/jqLite.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
* - [`contents()`](http://api.jquery.com/contents/)
* - [`css()`](http://api.jquery.com/css/)
* - [`data()`](http://api.jquery.com/data/)
* - [`detach()`](http://api.jquery.com/detach/)
* - [`empty()`](http://api.jquery.com/empty/)
* - [`eq()`](http://api.jquery.com/eq/)
* - [`find()`](http://api.jquery.com/find/) - Limited to lookups by tag name
Expand Down Expand Up @@ -368,6 +369,12 @@ function jqLiteEmpty(element) {
}
}

function jqLiteRemove(element, keepData) {
if (!keepData) jqLiteDealoc(element);
var parent = element.parentNode;
if (parent) parent.removeChild(element);
}

//////////////////////////////////////////
// Functions which are declared directly.
//////////////////////////////////////////
Expand Down Expand Up @@ -450,7 +457,7 @@ forEach({
return jqLiteInheritedData(element, '$injector');
},

removeAttr: function(element,name) {
removeAttr: function(element, name) {
element.removeAttribute(name);
},

Expand Down Expand Up @@ -796,10 +803,10 @@ forEach({
wrapNode.appendChild(element);
},

remove: function(element) {
jqLiteDealoc(element);
var parent = element.parentNode;
if (parent) parent.removeChild(element);
remove: jqLiteRemove,

detach: function(element) {
jqLiteRemove(element, true);
},

after: function(element, newElement) {
Expand Down