Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(select): allow multiline ng-options #5629

Closed
wants to merge 2 commits into from
Closed

feat(select): allow multiline ng-options #5629

wants to merge 2 commits into from

Conversation

jrupac
Copy link
Contributor

@jrupac jrupac commented Jan 4, 2014

This patch allows the ng-options value of a element to span multiple lines, which would previously throw an error when used with filters. Closes #5602

@jrupac
feat(select): allow multiline ng-options
34b4abb 
This patch allows the ng-options value of a <select> element to span
multiple lines, which would previously throw an error when used with filters.

Closes angular#5602
@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@jrupac
Copy link
Contributor Author

jrupac commented Jan 4, 2014

Hi Igor, I signed the CLA just after I added the commit with the email address ajay@roopakalu.com. Should I sign it again?

IgorMinar
IgorMinar reviewed Jan 4, 2014
View reviewed changes
src/ng/directive/select.js
@@ -129,7 +129,7 @@ var ngOptionsDirective = valueFn({ terminal: true });
// jshint maxlen: false
var selectDirective = ['$compile', '$parse', function($compile, $parse) {
//0000111110000000000022220000000000000000000000333300000000000000444444444444444000000000555555555555555000000066666666666666600000000000000007777000000000000000000088888
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also update this regexp grouping cheat-sheet

@IgorMinar
Copy link
Contributor

you used a different email address in the commit (see: https://github.com/angular/angular.js/pull/5629.patch)

please either update the commit or sign the CLA again with the email address used in the commit.

@jrupac
docs(select): update regexp grouping cheat-sheat
4de2c52 
Update the regexp grouping comment to reflect the changes needed for
multiline expressions in ng-options for <select>.

Closes angular#5602
@jrupac
Copy link
Contributor Author

jrupac commented Jan 4, 2014

I have now signed the CLA again with the correct email address, sorry about that!

@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@ghost ghost assigned jeffbcross Jan 6, 2014
@jeffbcross
Copy link
Contributor

Landed 8ace807

@jeffbcross jeffbcross closed this Jan 10, 2014
@jrupac jrupac deleted the multiline-select branch January 21, 2014 05:42
@esarbanis esarbanis mentioned this pull request Jun 25, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jeffbcross jeffbcross

Labels
cla: yes component: forms frequency: moderate type: bug type: feature
Projects
None yet
Milestone
1.2.8
Development

Successfully merging this pull request may close these issues.

ngOptions in <select> does not support free-style code
3 participants
@jrupac @IgorMinar @jeffbcross