Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($animate): prevent cancellation timestamp from being too far in the future #6793

Closed
wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Mar 21, 2014

Closes #6748

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6793)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

ss.addRule('.animate-me-longer div', '-webkit-transition:1.5s linear all;' +
'transition:1.5s linear all;');

element = $compile(html('<div class="animate-me-longer"><div ng-repeat="item in items"></div></div>'))($rootScope);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap

@IgorMinar
Copy link
Contributor

otherwise this looks good

@IgorMinar IgorMinar modified the milestones: 1.3.0-beta.4, 1.3.0 Mar 25, 2014
@matsko
Copy link
Contributor Author

matsko commented Mar 28, 2014

MERGED

@matsko
Copy link
Contributor Author

matsko commented Mar 28, 2014

Landed as ff5cf73

@matsko matsko closed this Mar 28, 2014
@matsko
Copy link
Contributor Author

matsko commented Mar 28, 2014

And as 35d635c for 1.2.x

@matsko matsko deleted the fix_leave branch March 28, 2014 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngAnimate leaves elements in DOM for a strange amount of time
4 participants