fix(ngSwitch): properly support case labels with different numbers of transclude fns #7373
Conversation
| previousElements[i].remove(); | ||
| } | ||
| previousElements = null; | ||
| previousElements.length = 0; |
There was a problem hiding this comment.
This isn't related to the change, but I didn't want to be creating new containers all the time, might get a little perf boost out of that.
… transclude fns Due to a regression introduced several releases ago, the ability for multiple transclude functions to work correctly changed, as they would break if different case labels had different numbers of transclude functions. This CL corrects this by not assuming that previous elements and scope count have the same length.
|
The bug is sort of hard to explain, basically, you can have multiple So the fix is just to make sure that the collections are iterated over correctly, because previousElements.length does not always match selectedScopes.length The other changes ( |
|
lgtm |
Due to a regression introduced several releases ago, the ability for multiple
transclude functions to work correctly changed, as they would break if
different case labels had different numbers of transclude functions.
This CL corrects this by not assuming that previous elements and scope count
have the same length.
Closes #7372