Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($parse): fix parsing error with leading space and one time bind #7641

Closed
wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

Easy way to fix #7640 : add a simple trim when expression is parsed.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7641)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@btford
Copy link
Contributor

btford commented May 30, 2014

This seems like the right thing to do. @caitp @IgorMinar thoughts?

@caitp
Copy link
Contributor

caitp commented May 30, 2014

I don't think it's a problem. My prototype did something similar, with regular expressions+grouping instead of trim, but since we don't need labels right now, maybe trim is a better approach.

edit by "I don't think it's a problem", I really mean LGTM

@IgorMinar
Copy link
Contributor

LGTM

@btford
Copy link
Contributor

btford commented Jun 2, 2014

Landed as 24c844d. Thanks @cexbrayat!

@btford btford closed this Jun 2, 2014
@btford btford removed their assignment Jun 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind once expressions with leading spaces are failing the parsing
6 participants