Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fix for Issue #912 ($position in repeat directive can't be both first and last at the same time) #928

Closed
wants to merge 8 commits into from

Conversation

maxmart
Copy link
Contributor

@maxmart maxmart commented May 2, 2012

Fix for issue #912 (#912)

Implementation of my suggested fix where three boolean values $first, $middle and $last replaces the $position variable. I also added a test case for single item lists.

@IgorMinar
Copy link
Contributor

this looks good to me. we need to document this as a breaking change, but I'm for merging this into master before 1.0 final

@IgorMinar
Copy link
Contributor

In order for us to be able to accept this change, can you please e-sign the contributors license agreement (CLA). It's quite straightforward:

For individuals (a simple click through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

@maxmart
Copy link
Contributor Author

maxmart commented May 4, 2012

Alright, sure thing.
It's done!

@IgorMinar
Copy link
Contributor

hey, sorry - this is taking longer than I'd like it to. we are going to release some other breaking changes in rc10 so I plan to merge this in at that time.

@maxmart
Copy link
Contributor Author

maxmart commented May 17, 2012

Sorry, I accidentally pushed to the wrong branch. These last commits are not supposed to be part of this pull request.
I'm kinda new to git, but I'll try to undo the commits.

@maxmart
Copy link
Contributor Author

maxmart commented May 17, 2012

As you can see I created a new pull request that references a branch instead of my master branch.

@maxmart maxmart closed this May 17, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants