Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Double directive controller instantiation fix #931

Merged
merged 6 commits into from
May 4, 2012
Merged

Double directive controller instantiation fix #931

merged 6 commits into from
May 4, 2012

Conversation

IgorMinar
Copy link
Contributor

No description provided.

IgorMinar added 6 commits May 3, 2012 23:31
@IgorMinar
style($compile): clean up the code and normalize fn names
fff31d8
@IgorMinar
style(jqLite): clean up the code
5df7e6f
@IgorMinar
feat(jqLite): support data() getter and data(obj) setter
ee579a0 
... just like jquery does
@IgorMinar
chore(testabilityPatch): print number of leaked references if any
a44d3dc
@IgorMinar
fix($compile): fix replaceWith
b431ee3 
the old implementation didn't reattach jquery/jqlite data which caused
things like  to be lost

I tried various implementations but it appears that by reattaching the data
to the new node by copying the expando property is the most reliable of all.
@IgorMinar
style($compile): rename orig*Node to beforeTemplate*Node
1564b82
@IgorMinar IgorMinar merged commit 1564b82 into angular:master May 4, 2012
@snyk-bot snyk-bot mentioned this pull request Sep 10, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorMinar @mhevery