Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix for issue #933:ng-repeat does not work with primitive types #944

Closed
wants to merge 4 commits into from

Conversation

zhenbzha
Copy link
Contributor

@zhenbzha zhenbzha commented May 8, 2012

@zhenbzha
Copy link
Contributor Author

zhenbzha commented May 9, 2012

  • use isObject() help function
  • use hasOwnProperty instead of checking undefined
  • remove obsolete indexvalues
  • add more unit tests
  • fix indentations ... I am using webstorm. and indentation looks fine in IDE, however, after checkin, indentation is messed up. now i have manually fix all(hopefully) indentation issues

Here are fiddles after fix for error scenario reported in this issue:
http://jsfiddle.net/zhenbzha/5PcxY/
http://jsfiddle.net/zhenbzha/uayCv/
http://jsfiddle.net/zhenbzha/YqtWw/1/
http://jsfiddle.net/zhenbzha/FhzDV/

@vojtajina
Copy link
Contributor

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

@zhenbzha
Copy link
Contributor Author

Hi,

CLA has been signed.

@mhevery
Copy link
Contributor

mhevery commented Aug 28, 2012

Thanks for signing CLA, and sorry for the long delay. Working on merging this in.

@mhevery
Copy link
Contributor

mhevery commented Aug 31, 2012

I am sorry I can not find you in our signing logs, and as a result I can not merge this. What name/email did you use when you signed it?

@zhenbzha
Copy link
Contributor Author

zhenbzha commented Sep 1, 2012

If remembered correctly ... : Zhenbo Zhang/zhenbo.zhang1981@gmail.com

@mhevery
Copy link
Contributor

mhevery commented Sep 4, 2012

MERGED

@mhevery mhevery closed this Sep 4, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants