This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat($route): ability to cancel $routeChangeStart event #9502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `preventDefault()` on a `$routeChangeStart` event will prevent the route change and also call `preventDefault` on the `$locationChangeStart` event, which prevents the location change as well. BREAKING CHANGE: Order of events has changed. Previously: `$locationChangeStart` -> `$locationChangeSuccess` -> `$routeChangeStart` -> `$routeChangeSuccess` Now: `$locationChangeStart` -> `$routeChangeStart` -> `$locationChangeSuccess` -> -> `$routeChangeSuccess` Fixes angular#5581 Closes angular#5714
|
@caitp Hi Caitlin, @IgorMinar and I just came up with this implementation to prevent route change. Can you take a look? |
tbosch
added a commit
that referenced
this pull request
Oct 8, 2014
Calling `preventDefault()` on a `$routeChangeStart` event will prevent the route change and also call `preventDefault` on the `$locationChangeStart` event, which prevents the location change as well. BREAKING CHANGE: Order of events has changed. Previously: `$locationChangeStart` -> `$locationChangeSuccess` -> `$routeChangeStart` -> `$routeChangeSuccess` Now: `$locationChangeStart` -> `$routeChangeStart` -> `$locationChangeSuccess` -> -> `$routeChangeSuccess` Fixes #5581 Closes #5714 Closes #9502
|
Not keen on the breaking change since this was perfectly implementable without it, but hey |
|
It wasn't without hacks that restored the location state.
|
|
cancelling $locationChangeStart should restore the location state, there is logic within $location itself to do that |
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
Calling `preventDefault()` on a `$routeChangeStart` event will prevent the route change and also call `preventDefault` on the `$locationChangeStart` event, which prevents the location change as well. BREAKING CHANGE: Order of events has changed. Previously: `$locationChangeStart` -> `$locationChangeSuccess` -> `$routeChangeStart` -> `$routeChangeSuccess` Now: `$locationChangeStart` -> `$routeChangeStart` -> `$locationChangeSuccess` -> -> `$routeChangeSuccess` Fixes angular#5581 Closes angular#5714 Closes angular#9502
| @@ -481,7 +533,7 @@ describe('$route', function() { | |||
|
|
|||
|
|
|||
| describe('events', function() { | |||
| it('should not fire $after/beforeRouteChange during bootstrap (if no route)', function() { | |||
| it('should not fire $routeChangeStart/success during bootstrap (if no route)', function() { | |||
There was a problem hiding this comment.
Yes, thanks for catching this. Could you create a PR to fix it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
preventDefault()on a$routeChangeStartevent willprevent the route change and also call
preventDefaulton the$locationChangeStartevent, which prevents the location change as well.BREAKING CHANGE:
Order of events has changed.
Previously:
$locationChangeStart->$locationChangeSuccess->
$routeChangeStart->$routeChangeSuccessNow:
$locationChangeStart->$routeChangeStart->
$locationChangeSuccess-> ->$routeChangeSuccessFixes #5581
Closes #5714