Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running unit tests in a new HTML Document creates failures in non-Chrome browsers #3475

Closed
marclaval opened this issue Aug 4, 2015 · 1 comment

Comments

@marclaval
Copy link
Contributor

2 weeks ago, we started running unit tests in a new HTML Document, see: https://github.com/angular/angular/blob/master/modules/angular2/src/test_lib/test_injector.ts#L96
If it works fine in Chrome, it creates problems in other browsers.

The biggest one is for Safari where events are not dispatched in such a document. This causes the 26 events-based unit tests to fail there.
It also generates one failure in Firefox and IE11. In Firefox, the default behaviour of an event is not applied (e.g. checkbox not checked after a click). In IE11, text selection feature doesn"t work.

Moving back to the real DOM doesn't seem to degrade performances, but it means loosing the isolation that is brought by a new Document. But it seems needed to be able to integrate these browsers to CI.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants