ng update modifies files out of the project #2907
Comments
|
This issue does not seem to follow the issue template. Make sure you provide all the required information. |
|
Yuck, sorry about that, I would've expected the angular workspace to only include the relevant files. Clearly I need to grab the project root. Thanks for reporting! |
jamesdaniels
added a commit
that referenced
this issue
Aug 30, 2021
Merged
jamesdaniels
added a commit
that referenced
this issue
Aug 30, 2021
### Bug fixes * **messaging:** `onMessage` will no longer destablize the Angular Zone * **core:** Injected Classes now have a better fallback pattern for finding defaults, [#2909](#2909) allowing use of emulators and other config options as expected * **schematic:** upgrade schematic will no longer rewrite `.ts` files outside of your project root, [#2907](#2907) ### Misc * **changelog(7.0.0):** break notice for `compat/auth#useEmulator` * **changelog(7.0.0):** feature of `compat/storage#useEmulator` * **changelog(7.0.1):** Added entry * **sample(modular):** Adding `connectEmulator` examples * **sample(compat):** Cleaned up the service worker registration * **functions:** defensively load auth first, if provided * **storage:** defensively load auth first, if provided * **compat/firestore:** clean up how auth is initialized * **compat/database:** clean up how auth is initialized
|
Cutting 7.0.1 now. Thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version info
Angular:
12.2.1
Firebase:
8.9.1
AngularFire:
6.1.5
Other (e.g. Ionic/Cordova, Node, browser, operating system):
macOS
Expected behavior
ng update @angular/firemodifies source files of the Angular project onlyActual behavior
ng update @angular/firemodifies source files outside of the angular project.I have a subdirectory
functionsin my root project directory, containing... a firebase function, with its own package.json etc. When running the update from the root directory containing the package.json for the Angular poject, the update also modifies the filefunctions/src/index.tsand replacesimport * as functions from 'firebase-functions';byimport * as functions from 'firebase/compat-functions';.The text was updated successfully, but these errors were encountered: