Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App check #2940

Merged
merged 5 commits into from
Sep 11, 2021
Merged

App check #2940

merged 5 commits into from
Sep 11, 2021

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Sep 11, 2021 •
edited
Loading

  • Adding @angular/fire/app-check
    • Right now AppCheck doesn't "allow" you to set the debug token global right before initialization as it's inspected as a side-effect. I devised a hack that wins the race. Downside here is that Angular hasn't been initialized yet, so in order to tell if Angular is in devmode I'm looking up global variables, which are subject to behavior changes. Request has been submitted to the JS SDK team..
  • Flushing out the samples a bit more, added appcheck
  • Changing the tsconfig path resolution so it doesn't have to be exhaustive

@jamesdaniels jamesdaniels mentioned this pull request Sep 11, 2021
Closed
@jamesdaniels jamesdaniels added this to the 7.1 milestone Sep 11, 2021
@jamesdaniels jamesdaniels merged commit 337116f into master Sep 11, 2021
@jamesdaniels jamesdaniels deleted the app-check branch September 11, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesdaniels @googlebot