Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(afs): Gracefully handle duplicate emissions on modified/deleted #1825

Merged
merged 1 commit into from
Aug 21, 2018
Merged

fix(afs): Gracefully handle duplicate emissions on modified/deleted #1825

merged 1 commit into from
Aug 21, 2018

Conversation

jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels requested a review from davideast August 21, 2018 20:12
@jamesdaniels jamesdaniels changed the title Gracefully handle duplicate emissions on modified/deleted fix(afs): Gracefully handle duplicate emissions on modified/deleted Aug 21, 2018
davideast
davideast approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davideast davideast merged commit 76ff6c1 into master Aug 21, 2018
@davideast davideast deleted the scan_fixes branch August 21, 2018 20:27
@jamesdaniels jamesdaniels mentioned this pull request Sep 1, 2018
Merged
sulco pushed a commit to sulco/angularfire2 that referenced this pull request Sep 3, 2018
@jamesdaniels @sulco
fix(afs): Gracefully handle duplicate emissions on modified/deleted (a…
ae93948 
…ngular#1825)
@jamesdaniels jamesdaniels mentioned this pull request Sep 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdaniels @davideast @googlebot