Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.7.0 does not work on intel macs #78

Closed
mikehardy opened this issue Apr 27, 2022 · 3 comments
Closed

v1.7.0 does not work on intel macs #78

mikehardy opened this issue Apr 27, 2022 · 3 comments

Comments

@mikehardy
Copy link

@mprobst the v1.7.0 mac executables are arm64:

mike@osxvm:~/work/Invertase/react-native-google-mobile-ads (@mikehardy/dependency-updates *) % cat node_modules/clang-format/package.json |grep version
  "version": "1.7.0",
mike@osxvm:~/work/Invertase/react-native-google-mobile-ads (@mikehardy/dependency-updates *) % file node_modules/clang-format/bin/darwin_x64/clang-format 
node_modules/clang-format/bin/darwin_x64/clang-format: Mach-O 64-bit executable arm64

If I yarn add clang-format@1.6.0 things work for me on a non-M1 mac:


mike@osxvm:~/work/Invertase/react-native-google-mobile-ads (@mikehardy/dependency-updates *) % cat node_modules/clang-format/package.json |grep version
  "version": "1.6.0",
mike@osxvm:~/work/Invertase/react-native-google-mobile-ads (@mikehardy/dependency-updates *) % file node_modules/clang-format/bin/darwin_x64/clang-format 
node_modules/clang-format/bin/darwin_x64/clang-format: Mach-O 64-bit executable x86_64

I'm jealous of your M1 machine but do not have plans to purchase one myself for a little while. Is there a way to publish x86_64 builds for maximum compatibility until M1 compatibility has handle more thoroughly?

@mikehardy
Copy link
Author

mikehardy commented Apr 27, 2022

Thank you for the library by the way, I use it a lot and even patterned a java format off it in homage: https://github.com/invertase/nodejs-google-java-format/#inspiration 😄 ❤️

mikehardy added a commit to invertase/react-native-google-mobile-ads that referenced this issue Apr 27, 2022
mikehardy added a commit to invertase/react-native-google-mobile-ads that referenced this issue Apr 27, 2022
@mprobst
Copy link
Contributor

mprobst commented Apr 29, 2022

@mikehardy I pushed 1.8.0 which should be back to x86_64 (see 140dcf5).

@mikehardy
Copy link
Author

Perfect! Confirmed working and I'm back to current for this dependency :-). Cheers

mikehardy added a commit to invertase/react-native-google-mobile-ads that referenced this issue Apr 29, 2022
codebytere added a commit to codebytere/node-mac-permissions that referenced this issue May 21, 2022
codebytere added a commit to codebytere/node-mac-permissions that referenced this issue May 26, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Aug 8, 2022
Summary:
- Current version of clang-format does not work on Apple M1/M2/... chipsets angular/clang-format#78

Changelog:
[General][Fixed] - Make clang-format work in M1 (Apple Silicon)

Reviewed By: cortinico

Differential Revision: D38505844

fbshipit-source-id: c94a71dea82217e725a3609d72692a15a8fe22e0
roryabraham pushed a commit to Expensify/react-native that referenced this issue Aug 17, 2022
Summary:
- Current version of clang-format does not work on Apple M1/M2/... chipsets angular/clang-format#78

Changelog:
[General][Fixed] - Make clang-format work in M1 (Apple Silicon)

Reviewed By: cortinico

Differential Revision: D38505844

fbshipit-source-id: c94a71dea82217e725a3609d72692a15a8fe22e0
roryabraham pushed a commit to Expensify/react-native that referenced this issue Aug 17, 2022
Summary:
- Current version of clang-format does not work on Apple M1/M2/... chipsets angular/clang-format#78

Changelog:
[General][Fixed] - Make clang-format work in M1 (Apple Silicon)

Reviewed By: cortinico

Differential Revision: D38505844

fbshipit-source-id: c94a71dea82217e725a3609d72692a15a8fe22e0
Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this issue Jun 7, 2024
Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this issue Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants