test: remove compileComponent calls (#29535)

Calls to `compileComponent` aren't necessary in the vast majority of cases. These changes clean them up frm our codebase.
angular · Aug 6, 2024 · 4718718 · 4718718
1 parent 78c6941
commit 4718718
Show file tree

Hide file tree

Showing 187 changed files with 438 additions and 625 deletions.
diff --git a/src/cdk-experimental/combobox/combobox.spec.ts b/src/cdk-experimental/combobox/combobox.spec.ts
@@ -26,7 +26,7 @@ describe('Combobox', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [CdkComboboxModule, ComboboxToggle],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {
@@ -192,7 +192,7 @@ describe('Combobox', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [CdkComboboxModule, ComboboxToggle],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {
@@ -262,7 +262,7 @@ describe('Combobox', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [CdkComboboxModule, ComboboxToggle],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {

diff --git a/src/cdk-experimental/popover-edit/popover-edit.spec.ts b/src/cdk-experimental/popover-edit/popover-edit.spec.ts
@@ -397,7 +397,7 @@ describe('CDK Popover Edit', () => {
         TestBed.configureTestingModule({
           imports: [CdkTableModule, CdkPopoverEditModule, CommonModule, FormsModule, BidiModule],
           declarations: [componentClass],
-        }).compileComponents();
+        });
         fixture = TestBed.createComponent<BaseTestComponent>(componentClass);
         component = fixture.componentInstance;
         fixture.detectChanges();

diff --git a/src/cdk-experimental/scrolling/virtual-scroll-viewport.spec.ts b/src/cdk-experimental/scrolling/virtual-scroll-viewport.spec.ts
@@ -12,7 +12,7 @@ describe('CdkVirtualScrollViewport', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [ScrollingModule, ExperimentalScrollingModule, AutoSizeVirtualScroll],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {

diff --git a/src/cdk-experimental/selection/selection.spec.ts b/src/cdk-experimental/selection/selection.spec.ts
@@ -14,7 +14,7 @@ describe('CdkSelection', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [CdkSelectionModule, ListWithMultiSelection],
-    }).compileComponents();
+    });
   }));
 
   beforeEach(() => {
@@ -240,7 +240,7 @@ describe('CdkSelection with multiple = false', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [CdkSelectionModule, ListWithSingleSelection],
-    }).compileComponents();
+    });
   }));
 
   beforeEach(() => {
@@ -305,7 +305,7 @@ describe('cdkSelectionColumn', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [CdkSelectionModule, CdkTableModule, MultiSelectTableWithSelectionColumn],
-    }).compileComponents();
+    });
   }));
 
   beforeEach(() => {
@@ -399,7 +399,7 @@ describe('cdkSelectionColumn with multiple = false', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [CdkSelectionModule, CdkTableModule, SingleSelectTableWithSelectionColumn],
-    }).compileComponents();
+    });
   }));
 
   beforeEach(() => {

diff --git a/src/cdk-experimental/table-scroll-container/table-scroll-container.spec.ts b/src/cdk-experimental/table-scroll-container/table-scroll-container.spec.ts
@@ -24,7 +24,7 @@ describe('CdkTableScrollContainer', () => {
   ): ComponentFixture<T> {
     TestBed.configureTestingModule({
       imports: [CdkTableModule, CdkTableScrollContainerModule, componentType, ...declarations],
-    }).compileComponents();
+    });
 
     return TestBed.createComponent<T>(componentType);
   }

diff --git a/src/cdk/a11y/aria-describer/aria-describer.spec.ts b/src/cdk/a11y/aria-describer/aria-describer.spec.ts
@@ -12,7 +12,7 @@ describe('AriaDescriber', () => {
     TestBed.configureTestingModule({
       imports: [A11yModule, TestApp],
       providers: [AriaDescriber, ...providers],
-    }).compileComponents();
+    });
 
     fixture = TestBed.createComponent(TestApp);
     component = fixture.componentInstance;

diff --git a/src/cdk/a11y/focus-monitor/focus-monitor.spec.ts b/src/cdk/a11y/focus-monitor/focus-monitor.spec.ts
@@ -59,7 +59,7 @@ describe('FocusMonitor', () => {
           },
         },
       ],
-    }).compileComponents();
+    });
   });
 
   beforeEach(inject([FocusMonitor], (fm: FocusMonitor) => {
@@ -478,7 +478,7 @@ describe('FocusMonitor with "eventual" detection', () => {
           },
         },
       ],
-    }).compileComponents();
+    });
   });
 
   beforeEach(inject([FocusMonitor], (fm: FocusMonitor) => {
@@ -515,7 +515,7 @@ describe('cdkMonitorFocus', () => {
         FocusMonitorOnCommentNode,
         ExportedFocusMonitor,
       ],
-    }).compileComponents();
+    });
   });
 
   describe('button with cdkMonitorElementFocus', () => {
@@ -827,7 +827,7 @@ describe('FocusMonitor observable stream', () => {
     TestBed.configureTestingModule({
       imports: [A11yModule, PlainButton],
       providers: [{provide: Platform, useValue: fakePlatform}],
-    }).compileComponents();
+    });
   });
 
   beforeEach(inject([FocusMonitor], (fm: FocusMonitor) => {
@@ -864,7 +864,7 @@ describe('FocusMonitor input label detection', () => {
   beforeEach(() => {
     TestBed.configureTestingModule({
       imports: [A11yModule, CheckboxWithLabel],
-    }).compileComponents();
+    });
   });
 
   beforeEach(inject([FocusMonitor], (fm: FocusMonitor) => {

diff --git a/src/cdk/a11y/focus-monitor/focus-monitor.zone.spec.ts b/src/cdk/a11y/focus-monitor/focus-monitor.zone.spec.ts
@@ -16,7 +16,7 @@ describe('FocusMonitor observable stream Zone.js integration', () => {
     TestBed.configureTestingModule({
       imports: [A11yModule, PlainButton],
       providers: [{provide: Platform, useValue: fakePlatform}, provideZoneChangeDetection()],
-    }).compileComponents();
+    });
   });
 
   beforeEach(inject([FocusMonitor], (fm: FocusMonitor) => {

diff --git a/src/cdk/a11y/focus-trap/configurable-focus-trap.spec.ts b/src/cdk/a11y/focus-trap/configurable-focus-trap.spec.ts
@@ -95,7 +95,7 @@ function createComponent<T>(
   TestBed.configureTestingModule({
     imports: [A11yModule, componentType],
     providers: providers,
-  }).compileComponents();
+  });
 
   return TestBed.createComponent<T>(componentType);
 }

diff --git a/src/cdk/a11y/focus-trap/event-listener-inert-strategy.spec.ts b/src/cdk/a11y/focus-trap/event-listener-inert-strategy.spec.ts
@@ -64,7 +64,7 @@ function createComponent<T>(
   TestBed.configureTestingModule({
     imports: [A11yModule, componentType],
     providers: providers,
-  }).compileComponents();
+  });
 
   return TestBed.createComponent<T>(componentType);
 }

diff --git a/src/cdk/a11y/focus-trap/focus-trap.spec.ts b/src/cdk/a11y/focus-trap/focus-trap.spec.ts
@@ -28,8 +28,6 @@ describe('FocusTrap', () => {
         FocusTrapWithAutoCaptureInShadowDom,
       ],
     });
-
-    TestBed.compileComponents();
   }));
 
   describe('with default element', () => {

diff --git a/src/cdk/accordion/accordion-item.spec.ts b/src/cdk/accordion/accordion-item.spec.ts
@@ -15,7 +15,6 @@ describe('CdkAccordionItem', () => {
         ItemGroupWithAccordion,
       ],
     });
-    TestBed.compileComponents();
   }));
 
   describe('single item', () => {

diff --git a/src/cdk/accordion/accordion.spec.ts b/src/cdk/accordion/accordion.spec.ts
@@ -11,7 +11,6 @@ describe('CdkAccordion', () => {
     TestBed.configureTestingModule({
       imports: [BrowserAnimationsModule, CdkAccordionModule, SetOfItems, NestedItems],
     });
-    TestBed.compileComponents();
   }));
 
   it('should ensure only one item is expanded at a time', () => {

diff --git a/src/cdk/bidi/directionality.spec.ts b/src/cdk/bidi/directionality.spec.ts
@@ -18,7 +18,7 @@ describe('Directionality', () => {
         ElementWithPredefinedUppercaseDir,
       ],
       providers: [{provide: DIR_DOCUMENT, useFactory: () => fakeDocument}],
-    }).compileComponents();
+    });
   }));
 
   describe('Service', () => {

diff --git a/src/cdk/clipboard/copy-to-clipboard.spec.ts b/src/cdk/clipboard/copy-to-clipboard.spec.ts
@@ -31,8 +31,6 @@ describe('CdkCopyToClipboard', () => {
     TestBed.configureTestingModule({
       imports: [ClipboardModule, CopyToClipboardHost],
     });
-
-    TestBed.compileComponents();
   }));
 
   beforeEach(() => {

diff --git a/src/cdk/dialog/dialog.spec.ts b/src/cdk/dialog/dialog.spec.ts
@@ -69,8 +69,6 @@ describe('Dialog', () => {
       ],
     });
 
-    TestBed.compileComponents();
-
     dialog = TestBed.inject(Dialog);
     mockLocation = TestBed.inject(Location) as SpyLocation;
     overlay = TestBed.inject(Overlay);
@@ -1131,7 +1129,6 @@ describe('Dialog with a parent Dialog', () => {
       ],
     });
 
-    TestBed.compileComponents();
     parentDialog = TestBed.inject(Dialog);
     fixture = TestBed.createComponent(ComponentThatProvidesMatDialog);
     childDialog = fixture.componentInstance.dialog;

diff --git a/src/cdk/drag-drop/directives/test-utils.spec.ts b/src/cdk/drag-drop/directives/test-utils.spec.ts
@@ -46,7 +46,6 @@ export function createComponent<T>(
     });
   }
 
-  TestBed.compileComponents();
   return TestBed.createComponent<T>(componentType);
 }
 

diff --git a/src/cdk/drag-drop/drag-drop-registry.spec.ts b/src/cdk/drag-drop/drag-drop-registry.spec.ts
@@ -18,7 +18,7 @@ describe('DragDropRegistry', () => {
   beforeEach(fakeAsync(() => {
     TestBed.configureTestingModule({
       imports: [DragDropModule, BlankComponent],
-    }).compileComponents();
+    });
 
     fixture = TestBed.createComponent(BlankComponent);
     fixture.detectChanges();

diff --git a/src/cdk/drag-drop/drag-drop.spec.ts b/src/cdk/drag-drop/drag-drop.spec.ts
@@ -13,7 +13,6 @@ describe('DragDrop', () => {
       imports: [DragDropModule, TestComponent],
     });
 
-    TestBed.compileComponents();
     service = TestBed.inject(DragDrop);
   }));
 

diff --git a/src/cdk/listbox/listbox.spec.ts b/src/cdk/listbox/listbox.spec.ts
@@ -21,7 +21,7 @@ function setupComponent<T, O = string>(component: Type<T>, imports: any[] = [])
   TestBed.configureTestingModule({
     imports: [CdkListboxModule, ...imports],
     declarations: [component],
-  }).compileComponents();
+  });
   const fixture = TestBed.createComponent(component);
   fixture.detectChanges();
 

diff --git a/src/cdk/menu/context-menu-trigger.spec.ts b/src/cdk/menu/context-menu-trigger.spec.ts
@@ -18,7 +18,7 @@ describe('CdkContextMenuTrigger', () => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule],
         declarations: [SimpleContextMenu],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {
@@ -152,7 +152,7 @@ describe('CdkContextMenuTrigger', () => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule],
         declarations: [NestedContextMenu],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {
@@ -267,7 +267,7 @@ describe('CdkContextMenuTrigger', () => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule],
         declarations: [ContextMenuWithSubmenu],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {
@@ -298,7 +298,7 @@ describe('CdkContextMenuTrigger', () => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule],
         declarations: [ContextMenuWithMenuBarAndInlineMenu],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {
@@ -402,7 +402,7 @@ describe('CdkContextMenuTrigger', () => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule],
         declarations: [componentClass],
-      }).compileComponents();
+      });
 
       const fixture = TestBed.createComponent(componentClass);
       fixture.detectChanges();
@@ -428,7 +428,7 @@ describe('CdkContextMenuTrigger', () => {
     TestBed.configureTestingModule({
       imports: [CdkMenuModule],
       declarations: [ContextTriggerWithData],
-    }).compileComponents();
+    });
 
     const fixture = TestBed.createComponent(ContextTriggerWithData);
     fixture.componentInstance.menuData = {message: 'Hello!'};

diff --git a/src/cdk/menu/menu-bar.spec.ts b/src/cdk/menu/menu-bar.spec.ts
@@ -47,7 +47,7 @@ describe('MenuBar', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule, MenuBarRadioGroup],
-      }).compileComponents();
+      });
 
       fixture = TestBed.createComponent(MenuBarRadioGroup);
       fixture.detectChanges();
@@ -107,7 +107,7 @@ describe('MenuBar', () => {
       beforeEach(waitForAsync(() => {
         TestBed.configureTestingModule({
           imports: [CdkMenuModule, MultiMenuWithSubmenu],
-        }).compileComponents();
+        });
       }));
 
       beforeEach(() => {
@@ -531,7 +531,7 @@ describe('MenuBar', () => {
       beforeEach(waitForAsync(() => {
         TestBed.configureTestingModule({
           imports: [CdkMenuModule, MultiMenuWithSubmenu],
-        }).compileComponents();
+        });
       }));
 
       beforeEach(() => {
@@ -658,7 +658,7 @@ describe('MenuBar', () => {
       beforeEach(waitForAsync(() => {
         TestBed.configureTestingModule({
           imports: [CdkMenuModule, MenuWithCheckboxes],
-        }).compileComponents();
+        });
       }));
 
       beforeEach(() => {
@@ -724,7 +724,7 @@ describe('MenuBar', () => {
       beforeEach(waitForAsync(() => {
         TestBed.configureTestingModule({
           imports: [CdkMenuModule, MenuWithRadioButtons],
-        }).compileComponents();
+        });
       }));
 
       beforeEach(() => {
@@ -779,7 +779,7 @@ describe('MenuBar', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule, MenuBarWithMenusAndInlineMenu],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {
@@ -898,7 +898,7 @@ describe('MenuBar', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule, MultiMenuWithSubmenu],
-      }).compileComponents();
+      });
     }));
 
     beforeEach(() => {

diff --git a/src/cdk/menu/menu-group.spec.ts b/src/cdk/menu/menu-group.spec.ts
@@ -14,7 +14,7 @@ describe('MenuGroup', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule, CheckboxMenu],
-      }).compileComponents();
+      });
 
       fixture = TestBed.createComponent(CheckboxMenu);
       fixture.detectChanges();
@@ -41,7 +41,7 @@ describe('MenuGroup', () => {
     beforeEach(waitForAsync(() => {
       TestBed.configureTestingModule({
         imports: [CdkMenuModule, MenuWithMultipleRadioGroups],
-      }).compileComponents();
+      });
 
       fixture = TestBed.createComponent(MenuWithMultipleRadioGroups);
       fixture.detectChanges();
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,8 +28,6 @@ describe('FocusTrap', () => { @@
             FocusTrapWithAutoCaptureInShadowDom,
           ],
         });
-        TestBed.compileComponents();
       }));
       describe('with default element', () => {
@@ Expand Down @@