Skip to content

Commit

Permalink
fix(material/dialog): updates dialog max-height in landscape (#29853)
Browse files Browse the repository at this point in the history
* fix(material/dialog): updates dialog max-height in landscape

Updates Angular Component Dialog component to have a max-height of
95vh which gives it a calculable height for its contents to adjust
on smaller screens or in landscape mode so that the action buttons
are able to be accessed by scrolling rather than the dialog window
cutting them off.

Fixes b/323588333

* refactor(material/dialog): reverted max-height to inherit

Updates previous fix to revert max-height back to inherit.

Fixes b/323588333
  • Loading branch information
essjay05 authored Oct 10, 2024
1 parent 4869909 commit da9cb71
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/material/dialog/dialog.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ $mat-dialog-content-max-height: 65vh !default;
// don't expose this value as variable.
$mat-dialog-button-horizontal-margin: 8px !default;

// Dialog container max height. This has been given a default value so the
// flex-children can be calculated and not overflow on smaller screens.
// Fixes b/323588333
$mat-dialog-container-max-height: 95vh !default;

// Whether to emit fallback values for the structural styles. Previously MDC was emitting
// paddings in the static styles which meant that users would get them even if they didn't
// include the `dialog-base`. Eventually we should clean up the usages of this flag.
Expand Down

0 comments on commit da9cb71

Please sign in to comment.