addressed comments

angular · Feb 8, 2017 · f9155be · f9155be
1 parent f5486a8
commit f9155be
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 5 deletions.
diff --git a/src/lib/core/style/focus-classes.spec.ts b/src/lib/core/style/focus-classes.spec.ts
@@ -180,6 +180,28 @@ describe('FocusOriginMonitor', () => {
       expect(changeHandler).toHaveBeenCalledWith('program');
     }, 0);
   }));
+
+  it('should remove focus classes on blur', async(() => {
+    if (platform.FIREFOX) { return; }
+
+    buttonElement.focus();
+    fixture.detectChanges();
+
+    setTimeout(() => {
+      fixture.detectChanges();
+
+      expect(buttonElement.classList.length)
+          .toBe(2, 'button should have exactly 2 focus classes');
+      expect(changeHandler).toHaveBeenCalledWith('program');
+
+      buttonElement.blur();
+      fixture.detectChanges();
+
+      expect(buttonElement.classList.length)
+          .toBe(0, 'button should not have any focus classes');
+      expect(changeHandler).toHaveBeenCalledWith(null);
+    }, 0);
+  }));
 });
 
 
@@ -275,6 +297,28 @@ describe('cdkFocusClasses', () => {
       expect(changeHandler).toHaveBeenCalledWith('program');
     }, 0);
   }));
+
+  it('should remove focus classes on blur', async(() => {
+    if (platform.FIREFOX) { return; }
+
+    buttonElement.focus();
+    fixture.detectChanges();
+
+    setTimeout(() => {
+      fixture.detectChanges();
+
+      expect(buttonElement.classList.length)
+          .toBe(2, 'button should have exactly 2 focus classes');
+      expect(changeHandler).toHaveBeenCalledWith('program');
+
+      buttonElement.blur();
+      fixture.detectChanges();
+
+      expect(buttonElement.classList.length)
+          .toBe(0, 'button should not have any focus classes');
+      expect(changeHandler).toHaveBeenCalledWith(null);
+    }, 0);
+  }));
 });
 
 

diff --git a/src/lib/core/style/focus-classes.ts b/src/lib/core/style/focus-classes.ts
@@ -12,8 +12,8 @@ export class FocusOriginMonitor {
   /** The focus origin that the next focus event is a result of. */
   private _origin: FocusOrigin = null;
 
-  /** A WeakMap used to track the last element focused via the FocusOriginMonitor. */
-  private _lastFocused = new WeakMap<Element, FocusOrigin>();
+  /** The FocusOrigin of the last focus event tracked by the FocusOriginMonitor. */
+  private _lastFocusOrigin: FocusOrigin;
 
   /** Whether the window has just been focused. */
   private _windowFocused = false;
@@ -63,8 +63,8 @@ export class FocusOriginMonitor {
     // 2) The element was programmatically focused, in which case we should mark the origin as
     //    'program'.
     if (!this._origin) {
-      if (this._windowFocused && this._lastFocused.has(element)) {
-        this._origin = this._lastFocused.get(element);
+      if (this._windowFocused && this._lastFocusOrigin) {
+        this._origin = this._lastFocusOrigin;
       } else {
         this._origin = 'program';
       }
@@ -76,7 +76,7 @@ export class FocusOriginMonitor {
     renderer.setElementClass(element, 'cdk-program-focused', this._origin == 'program');
 
     subject.next(this._origin);
-    this._lastFocused = new WeakMap().set(element, this._origin);
+    this._lastFocusOrigin = this._origin;
     this._origin = null;
   }