Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(datepicker): previous/next month buttons missing hover state #18958

Closed
mmalerba opened this issue Mar 31, 2020 · 1 comment · Fixed by #18995
Closed

bug(datepicker): previous/next month buttons missing hover state #18958

mmalerba opened this issue Mar 31, 2020 · 1 comment · Fixed by #18995
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mmalerba
Copy link
Contributor

Repro: See basic datepicker example at https://material.angular.io/components/datepicker/overview
@mmalerba mmalerba added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) labels Mar 31, 2020
@mmalerba mmalerba mentioned this issue Mar 31, 2020
Closed
@crisbeto crisbeto self-assigned this Apr 5, 2020
@crisbeto crisbeto added the has pr label Apr 5, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 5, 2020
@crisbeto
fix(datepicker): add hover indication to navigation buttons
c8507cd 
The calendar navigation buttons use `mat-icon-button` which explicitly doesn't have hover indication for some reason (see https://github.com/angular/components/blob/master/src/material/button/button.scss#L13). I'm not exactly sure about the reasoning in `mat-button`, so I decided to scope these changes only to the calendar so we don't cause unexpected behavior.

Fixes angular#18958.
@crisbeto crisbeto mentioned this issue Apr 5, 2020
Merged
mmalerba pushed a commit that referenced this issue Apr 7, 2020
@crisbeto @mmalerba
fix(datepicker): add hover indication to navigation buttons
32c02fe 
The calendar navigation buttons use `mat-icon-button` which explicitly doesn't have hover indication for some reason (see https://github.com/angular/components/blob/master/src/material/button/button.scss#L13). I'm not exactly sure about the reasoning in `mat-button`, so I decided to scope these changes only to the calendar so we don't cause unexpected behavior.

Fixes #18958.
mmalerba pushed a commit that referenced this issue Apr 7, 2020
@crisbeto @mmalerba
fix(datepicker): add hover indication to navigation buttons
30069c1 
The calendar navigation buttons use `mat-icon-button` which explicitly doesn't have hover indication for some reason (see https://github.com/angular/components/blob/master/src/material/button/button.scss#L13). I'm not exactly sure about the reasoning in `mat-button`, so I decided to scope these changes only to the calendar so we don't cause unexpected behavior.

Fixes #18958.
mmalerba pushed a commit that referenced this issue Apr 7, 2020
@crisbeto
fix(datepicker): add hover indication to navigation buttons (#18995)
049a11b 
The calendar navigation buttons use `mat-icon-button` which explicitly doesn't have hover indication for some reason (see https://github.com/angular/components/blob/master/src/material/button/button.scss#L13). I'm not exactly sure about the reasoning in `mat-button`, so I decided to scope these changes only to the calendar so we don't cause unexpected behavior.

Fixes #18958.
mmalerba pushed a commit that referenced this issue Apr 14, 2020
@crisbeto @mmalerba
fix(datepicker): add hover indication to navigation buttons (#18995)
94ab707 
The calendar navigation buttons use `mat-icon-button` which explicitly doesn't have hover indication for some reason (see https://github.com/angular/components/blob/master/src/material/button/button.scss#L13). I'm not exactly sure about the reasoning in `mat-button`, so I decided to scope these changes only to the calendar so we don't cause unexpected behavior.

Fixes #18958.
This was referenced May 3, 2020
Merged
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(datepicker): add hover indication to navigation buttons crisbeto/material2
2 participants
@crisbeto @mmalerba