-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter "system-variables-prefix" is not used by "mat.system-level-colors" mixin #29504
Closed
1 task
Labels
area: theming
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Comments
amysorto
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
area: theming
and removed
needs triage
This issue needs to be triaged by the team
labels
Jul 29, 2024
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Jul 30, 2024
…ome mixins Fixes that the `system-level-colors` and `system-level-typography` mixins weren't using the `system-variables-prefix` passed in by the user. Note: a bit of a gotcha here is that we need to store two separate prefixes, because in theory the user can pass different prefixes into `color` and `typography`. Fixes angular#29504.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Jul 30, 2024
…ome mixins Fixes that the `system-level-colors` and `system-level-typography` mixins weren't using the `system-variables-prefix` passed in by the user. Note: a bit of a gotcha here is that we need to store two separate prefixes, because in theory the user can pass different prefixes into `color` and `typography`. Fixes angular#29504.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Jul 30, 2024
…ome mixins Fixes that the `system-level-colors` and `system-level-typography` mixins weren't using the `system-variables-prefix` passed in by the user. Note: a bit of a gotcha here is that we need to store two separate prefixes, because in theory the user can pass different prefixes into `color` and `typography`. Fixes angular#29504.
crisbeto
added a commit
that referenced
this issue
Jul 30, 2024
…ome mixins (#29513) Fixes that the `system-level-colors` and `system-level-typography` mixins weren't using the `system-variables-prefix` passed in by the user. Note: a bit of a gotcha here is that we need to store two separate prefixes, because in theory the user can pass different prefixes into `color` and `typography`. Fixes #29504.
crisbeto
added a commit
that referenced
this issue
Jul 30, 2024
…ome mixins (#29513) Fixes that the `system-level-colors` and `system-level-typography` mixins weren't using the `system-variables-prefix` passed in by the user. Note: a bit of a gotcha here is that we need to store two separate prefixes, because in theory the user can pass different prefixes into `color` and `typography`. Fixes #29504. (cherry picked from commit 6d70114)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: theming
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Is this a regression?
The previous version in which this bug was not present was
No response
Description
When the parameter "system-variables-prefix" is used, the custom variables generated by "mat.system-level-colors" still have the "--sys" prefix
Reproduction
StackBlitz link: https://stackblitz.com/edit/stackblitz-starters-u6bo3u?file=src%2Fm3-theme.scss
Steps to reproduce:
Expected Behavior
Generated custom variables should have the prefix provided in the "system-variables-prefix" parameter both for colors and typography
Actual Behavior
Generated custom variables always have the "--sys" prefix, even if the "system-variables-prefix" parameter is provided
Environment
The text was updated successfully, but these errors were encountered: