-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(TABLE): cell with mat-cell directive is missing role="cell" attribute #29784
Comments
Confirmed role="cell" appears in v16 but not in v17 and v18. For documentation this is where the cell role is coming from: https://github.com/angular/components/blob/main/src/cdk/table/table.ts#L467 |
We were omitting `role="cell"` on native `td` elements, because the browser should be setting it implicitly, but based on the discussion in angular#29784, it seems like Safari doesn't do it. These changes switch to always setting the `role`. Fixes angular#29784.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Is this a regression?
The previous version in which this bug was not present was
16.2.14
Description
When using mat-table and mat-cell it used to have role="cell" for each cell in the table. Now there is not role attribute in cell elements.
Reproduction
Reproduction link: https://v17.material.angular.io/components/table/examples
You can check examples in 'Examples' tab on official docs website.
Steps to reproduce:
Previous version with expected behavior: https://v16.material.angular.io/components/table/examples
Steps to reproduce:
Expected Behavior
Cell has role="cell" attribute.
Actual Behavior
Cell does not have role="cell" attribute.
Environment
The text was updated successfully, but these errors were encountered: