Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(Timepicker): Disabled not working in FormControl #30134

Closed
1 task
horesse opened this issue Dec 5, 2024 · 1 comment · Fixed by #30137
Closed
1 task

bug(Timepicker): Disabled not working in FormControl #30134

horesse opened this issue Dec 5, 2024 · 1 comment · Fixed by #30137
Assignees
@crisbeto
Labels
area: material/timepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@horesse
Copy link

horesse commented Dec 5, 2024

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

The disabled property does not work correctly in timepicker. It blocks the time selection, but the selection from the menu is available

Reproduction

StackBlitz link: https://stackblitz.com/edit/czbajk?file=src%2Fexample%2Ftimepicker-datepicker-integration-example.html
Steps to reproduce:

  1. Use FormControl
  2. Disable input
  3. U can change time

Expected Behavior

Lock time selector

Actual Behavior

Time selection is available

Environment

  • Angular: 19.0.0 - 19.0.2
  • CDK/Material: latest
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@horesse horesse added the needs triage This issue needs to be triaged by the team label Dec 5, 2024
@crisbeto crisbeto self-assigned this Dec 5, 2024
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/timepicker and removed needs triage This issue needs to be triaged by the team labels Dec 6, 2024
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 6, 2024
@crisbeto
fix(material/timepicker): disable toggle if timepicker is disabled
6d9a912 
Fixes that the timepicker toggle wasn't considered as disabled automatically when the timepicker is disabled.

Fixes angular#30134.
@crisbeto crisbeto mentioned this issue Dec 6, 2024
Merged
@crisbeto
Copy link
Member

crisbeto commented Dec 6, 2024

Sent a fix at #30137 which will be in next week's release. Until it's fixed, you can work around it by setting the disabled attribute on mat-timepicker-toggle.

crisbeto added a commit that referenced this issue Dec 9, 2024
@crisbeto
fix(material/timepicker): disable toggle if timepicker is disabled (#…
4b69162 
…30137)

Fixes that the timepicker toggle wasn't considered as disabled automatically when the timepicker is disabled.

Fixes #30134.

(cherry picked from commit db8f6c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisbeto crisbeto

Labels
area: material/timepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/timepicker): disable toggle if timepicker is disabled crisbeto/material2
2 participants
@crisbeto @horesse