Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling Ripples on md-select #5801

Closed
yashsriv opened this issue Jul 16, 2017 · 2 comments
Closed

Allow disabling Ripples on md-select #5801

yashsriv opened this issue Jul 16, 2017 · 2 comments
Assignees
@devversion
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@yashsriv
Copy link

yashsriv commented Jul 16, 2017 •
edited
Loading

Bug, feature request, or proposal:

Feature Request

What is the expected behavior?

<md-select disableRipple> or <md-option disableRipple> should prevent ripples
on select options

What is the current behavior?

Both <md-select disableRipple> or <md-option disableRipple> do not prevent ripples
on select options.

What are the steps to reproduce?

http://plnkr.co/edit/mr95fO8ngrq3MDXNH146

What is the use-case or motivation for changing an existing behavior?

Ripples are very heavy on mobile phones and I'd like to disable ripples only on certain
elements where lag is not preferred. I know that there is an option to disable ripples
globally. I'm not looking for that.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4+, material beta-2+
@devversion devversion self-assigned this Jul 16, 2017
devversion added a commit to devversion/material2 that referenced this issue Jul 20, 2017
@devversion
feat(option): support for disableRipple binding
7441fab 
* Allows disabling ripples for md-option elements.

References angular#5801
@devversion devversion mentioned this issue Jul 20, 2017
Merged
kara pushed a commit that referenced this issue Jul 21, 2017
@devversion @kara
feat(option): support for disableRipple binding
474d099 
* Allows disabling ripples for md-option elements.

References #5801
@jelbourn jelbourn added feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Jul 25, 2017
@devversion
Copy link
Member

Solved with #5967

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jelbourn @devversion @yashsriv