-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] - Follow specs on guidelines #6202
Comments
Thanks for the help on getting this up to spec. We have an open PR regarding the sort animation #5831. I'll look into adding the 'light' sort icon on hover to indicate what the next sort would be. With regards to the column names and selection UX, I think that is going to be more suited for our |
Doesn't it makes sense to add these really basic things (I mean apply the correct styles to existent css classes - to hover, selection and show elipse in long header names) to follow up the specs in Also, it's not mentioned in guidelines, but I saw a image there and in pagination section it shows: |
Our design of the For example, column headers can be any template in the In addition, it will automatically include selection so it will make sense for us to include hover, active, and selected style states. In the With regards to the pagination, we went with |
@andrewseguin Thanks for the explanations. I have more two things here: 1 - In all examples in the specs the sort icon comes before the column name. In 2 - I have the impression that there's something really strange on sort icons. If you have some items like:
But currently it's:
If you inspect the class element, when the sort direction is "asc", the class applied is See this plunker: https://plnkr.co/edit/1oJk6enLig9UeN5NCAGh?p=info |
The sort icon can either be positioned to the left or right with the I think your example didn't save, I don't see it different from the regular sort example |
Oh, thanks for the Can you re-check the example? I really don't know what's happening, but it's not the expected behavior... You can see this in plunker... when the sort direction is desc, it sorts ascending and vice-versa. |
@andrewseguin I think this PR solves part of this, specifically the icon part, but IMHO the behavior is still incorrect as I described. Can you take a look? |
@andrewseguin could you point to the issue where the row selection is mentioned? It is a spec of data tables, so I assume it will be implemented. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Proposal?
What is the expected behavior?
Follow all the specs of data-table.
The text was updated successfully, but these errors were encountered: