Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sort] Sort icon should appear on hover #6858

Closed
andrewseguin opened this issue Sep 5, 2017 · 7 comments · Fixed by #7608
Closed

[Sort] Sort icon should appear on hover #6858

andrewseguin opened this issue Sep 5, 2017 · 7 comments · Fixed by #7608
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix

Comments

@andrewseguin
Copy link
Contributor

The spec says that the sort icons should appear when the header is hovered to indicate that the header is sortable.

@andrewseguin andrewseguin self-assigned this Sep 5, 2017
@jelbourn jelbourn added the P5 The team acknowledges the request but does not plan to address it, it remains open for discussion label Sep 6, 2017
@donroyco
Copy link
Contributor

donroyco commented Sep 8, 2017

@andrewseguin How would you do this on mobile devices?

@andrewseguin
Copy link
Contributor Author

Perhaps similar to tooltip, longpress can expose the icon without triggering the sort.

@willshowell
Copy link
Contributor

I'd like to piggy back on this to suggest similar behavior on focus. Currently there is no visual indication that an action can be taken when tabbing through the mat-sort-header-buttons.

@Misiu
Copy link

Misiu commented Oct 13, 2017

@andrewseguin does this mean that user won't see what column is sorted when he enters site? The only way to know what column is sorted will be to hover over header? Will there be an option to show sort icons by default and not when header is hovered?

@willshowell
Copy link
Contributor

@Misiu I believe the change will do the following

  1. If a column is not yet sorted, hovering/focusing/longpressing the header will show the sort icon
  2. If a column is sorted, the icon will show until the column becomes unsorted (existing behavior)

@Misiu
Copy link

Misiu commented Oct 13, 2017

I got confused because I thought that sort icons will only show when hovering.
@willshowell thanks for clarification.

@andrewseguin andrewseguin added feature This issue represents a new feature or feature request rather than a bug or bug fix has pr and removed mat-table labels Oct 19, 2017
@andrewseguin andrewseguin changed the title [Table] Sort icon should appear on hover [Sort] Sort icon should appear on hover Jan 23, 2018
@andrewseguin andrewseguin removed the P5 The team acknowledges the request but does not plan to address it, it remains open for discussion label May 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants