Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdTooltip null reference property 'isVisible' on ESC key press #7009

Closed
TishchenkoAlex opened this issue Sep 12, 2017 · 1 comment · Fixed by #7028
Closed

MdTooltip null reference property 'isVisible' on ESC key press #7009

TishchenkoAlex opened this issue Sep 12, 2017 · 1 comment · Fixed by #7028
Assignees

Comments

@TishchenkoAlex
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

no error in console

What is the current behavior?

error in console

Cannot read property 'isVisible' of null
at MdTooltip._handleKeydown

line 276 from tooltip.ts
/** Handles the keydown events on the host element. */ _handleKeydown(e: KeyboardEvent) { if (this._tooltipInstance!.isVisible() && e.keyCode === ESCAPE) { e.stopPropagation(); this.hide(0); } }

What are the steps to reproduce?

http://plnkr.co/edit/8fIEmoi4IkPWSycODZ5R?p=preview

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4.3.6
Material beta 10
TS 2.5

Is there anything else we should know?

@crisbeto crisbeto self-assigned this Sep 12, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 12, 2017
Fixes an error being thrown when pressing escape on a tooltip trigger that isn't showing a tooltip.

Fixes angular#7009.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 12, 2017
Fixes an error being thrown when pressing escape on a tooltip trigger that isn't showing a tooltip.

Fixes angular#7009.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 13, 2017
Fixes an error being thrown when pressing escape on a tooltip trigger that isn't showing a tooltip.

Fixes angular#7009.
jelbourn pushed a commit that referenced this issue Sep 19, 2017
Fixes an error being thrown when pressing escape on a tooltip trigger that isn't showing a tooltip.

Fixes #7009.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants