Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form-field] inconsistencies now that select is supported #7297

Closed
willshowell opened this issue Sep 25, 2017 · 2 comments · Fixed by #7727
Closed

[form-field] inconsistencies now that select is supported #7297

willshowell opened this issue Sep 25, 2017 · 2 comments · Fixed by #7727
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@willshowell
Copy link
Contributor

willshowell commented Sep 25, 2017

Bug, feature request, or proposal:

Bug

Current Behavior

  1. getMdFormFieldMissingControlError needs an updated message to reflect support for multiple types of controls

https://github.com/angular/material2/blob/3571f68a2de0833ee4741af8a0eb24d1da174f38/src/lib/form-field/form-field-errors.ts#L19-L23

  1. MdFormFieldModule is re-exported by MdInputModule but not by MdSelectModule. (tracking fix(paginator): page size selector not working #7263)

https://github.com/angular/material2/blob/3571f68a2de0833ee4741af8a0eb24d1da174f38/src/lib/input/input-module.ts#L27-L33

https://github.com/angular/material2/blob/3571f68a2de0833ee4741af8a0eb24d1da174f38/src/lib/select/select-module.ts#L23

cc @mmalerba

@josephperrott josephperrott added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Sep 25, 2017
@ghd8
Copy link

ghd8 commented Sep 25, 2017

fyi - second point was already corrected in #7263

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants