fix(paginator): page size selector not working #7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
added
the
P1
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
paginator-select
branch
from
dc23b90
to
02d6a2f
Compare
* Fixes the page size selection stretching to 100% of the paginator. * Fixes the `MdFormFieldModule` not being imported by `md-select`, causing it to look wrong.
crisbeto
force-pushed
the
paginator-select
branch
from
02d6a2f
to
b0ab517
Compare
|
Thank you for fixing this. This is the last issue that I've found when upgrading from beta.11 to master (which I need due to the nested menu fixes). Are the screenshot test failures blocking this? They seem unrelated to this PR. Hopefully this can get merged soon. |
|
The screenshot tests are non-blocking and the fix should be merged soon @Splaktar. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MdFormFieldModulenot being imported bymd-select, causing it to look wrong.