Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(md-select): repaint on scroll (Google Chrome) #7716

Closed
Ploppy3 opened this issue Oct 11, 2017 · 2 comments · Fixed by #7721
Closed

perf(md-select): repaint on scroll (Google Chrome) #7716

Ploppy3 opened this issue Oct 11, 2017 · 2 comments · Fixed by #7721
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@Ploppy3
Copy link

Ploppy3 commented Oct 11, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

It should not repaint on scroll

What is the current behavior?

It repaints on scroll
image

What are the steps to reproduce?

https://stackblitz.com/edit/angular-material2-issue-vyd5mg

What is the use-case or motivation for changing an existing behavior?

Performance matters.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material 2.0.0-beta.12
@Ploppy3 Ploppy3 changed the title md-select: repaint on scroll (Google Chrome) perf(md-select): repaint on scroll (Google Chrome) Oct 11, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 11, 2017
@crisbeto
perf(drawer): drawer content repainting on scroll
ed4c68c 
Prevents the drawer content from repainting while scrolling.

Relates to angular#7716.
@crisbeto crisbeto mentioned this issue Oct 11, 2017
Merged
@crisbeto crisbeto self-assigned this Oct 11, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 11, 2017
@crisbeto
perf(menu,select): panel repainting on scroll
7213b1b 
Prevents the menu and select panels from repainting while scrolling.

Fixes angular#7716.
@crisbeto crisbeto mentioned this issue Oct 11, 2017
Merged
andrewseguin pushed a commit that referenced this issue Oct 12, 2017
@crisbeto @andrewseguin
perf(drawer): drawer content repainting on scroll (#7719)
131e98f 
Prevents the drawer content from repainting while scrolling.

Relates to #7716.
@crisbeto crisbeto added the P4 A relatively minor issue that is not relevant to core functions label Nov 28, 2017
jelbourn pushed a commit that referenced this issue Jan 25, 2018
@crisbeto @jelbourn
perf(menu,select): panel repainting on scroll (#7721)
13410bd 
Prevents the menu and select panels from repainting while scrolling.

Fixes #7716.
@maxime1992
Copy link

Shouldn't be that done nearly everywhere?

For example this behaviour is still present on table, which is not great when there's quite some lines.

I know that we can use the pagination but still, feels like it might be faster for tables with 50 or 100 items

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(menu,select): panel repainting on scroll crisbeto/material2
3 participants
@crisbeto @maxime1992 @Ploppy3