Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components should only fire a change event when they are focused #791

Closed
jelbourn opened this issue Jun 30, 2016 · 2 comments · Fixed by #911
Closed

Components should only fire a change event when they are focused #791

jelbourn opened this issue Jun 30, 2016 · 2 comments · Fixed by #911
Labels
P2 The issue is important to a large percentage of users, with a workaround
Milestone
alpha.7

Comments

@jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Jun 30, 2016
@jelbourn jelbourn added this to the alpha.7 milestone Jun 30, 2016
@jelbourn jelbourn mentioned this issue Jun 30, 2016
Closed
@devversion devversion mentioned this issue Jul 6, 2016
Merged
@renevall renevall mentioned this issue Jul 6, 2016
Closed
@devversion
Copy link
Member

FYI: A better approach has been landed in master. We only emit a change event, when the native input emits one.

  • This makes sure, that the given component completely matches the native component behavior.

Already fixed for: md-slide-toggle, md-checkbox

devversion added a commit to devversion/material2 that referenced this issue Jul 23, 2016
@devversion
fix(radio): radio-button should only emit change event if native inpu…
6e1a5e0 
…t does.

* The radio-button should only emit a change event, when the native input does.
  This ensures that the radio-button matches its behavior with the native radio buttons.

Breaking Change: radio-button will no longer emit change event on de-select.

Fixes angular#791
@devversion devversion mentioned this issue Jul 23, 2016
Merged
devversion added a commit to devversion/material2 that referenced this issue Aug 8, 2016
@devversion
fix(radio): radio-button should only emit change event if native inpu…
e8d27f4 
…t does.

* The radio-button should only emit a change event, when the native input does.
  This ensures that the radio-button matches its behavior with the native radio buttons.

Breaking Change: radio-button will no longer emit change event on de-select.

Fixes angular#791
jelbourn pushed a commit that referenced this issue Aug 8, 2016
@devversion @jelbourn
fix(radio): only emit change event if native input does. (#911)
23a61ab 
* fix(radio): radio-button should only emit change event if native input does.

* The radio-button should only emit a change event, when the native input does.
  This ensures that the radio-button matches its behavior with the native radio buttons.

Breaking Change: radio-button will no longer emit change event on de-select.

Fixes #791

* Add todo for internal.

* update: button-toggle should emit change event when native input does.

* tests: add tests for button toggle change events
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
alpha.7
Development

Successfully merging a pull request may close this issue.

fix(radio): radio-button should only emit change event if native input does. devversion/material2
2 participants
@jelbourn @devversion