Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): ripple not clipping correctly in safari #12244

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

crisbeto
Copy link
Member

Fixes the ripple on a mat-chip not being clipped to the rounded corners on Safari.

Fixes the ripple on a `mat-chip` not being clipped to the rounded corners on Safari.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 17, 2018
@crisbeto crisbeto requested a review from tinayuangao as a code owner July 17, 2018 10:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 17, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 17, 2018
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 21, 2018
Fixes the ripples on buttons and button toggles not being clipped to the border radius in Safari.

Relates to angular#12244.
jelbourn pushed a commit that referenced this pull request Aug 25, 2018
Fixes the ripples on buttons and button toggles not being clipped to the border radius in Safari.

Relates to #12244.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 28, 2018
Fixes the ripples on buttons and button toggles not being clipped to the border radius in Safari.

Relates to angular#12244.
@vivian-hu-zz vivian-hu-zz merged commit eb95e61 into angular:master Oct 4, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
Fixes the ripple on a `mat-chip` not being clipped to the rounded corners on Safari.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 2, 2019
Fixes the ripples on buttons and button toggles not being clipped to the border radius in Safari.

Relates to angular#12244.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jun 4, 2019
Fixes the ripples on buttons and button toggles not being clipped to the border radius in Safari.

Relates to angular#12244.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants