chore: remove BooleanFieldValue #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
hansl
previously requested changes
Sep 21, 2016
| @@ -21,7 +21,8 @@ import { | |||
| FormsModule, | |||
| } from '@angular/forms'; | |||
| import {Observable} from 'rxjs/Observable'; | |||
| import {BooleanFieldValue, MdUniqueSelectionDispatcher} from '@angular2-material/core'; | |||
| import {MdUniqueSelectionDispatcher} from '@angular2-material/core'; | |||
| import {coerceBooleanProperty} from '../core/coersion/boolean-property'; | |||
There was a problem hiding this comment.
Either wait for my PR to be merged in (where you can use ../core) or fix those imports to pass the linting.
|
Yeah, I planned on waiting for your PR |
jelbourn
force-pushed
the
bool-property
branch
from
2f73586 to
710890e
Compare
|
@hansl rebased |
devversion
reviewed
Oct 5, 2016
| @Input() name: string = null; | ||
| @Input() id: string = this._uniqueId; | ||
| @Input() tabIndex: number = 0; | ||
| @Input() ariaLabel: string = null; | ||
| @Input() ariaLabelledby: string = null; | ||
|
|
||
| private _disabled: boolean = false; |
There was a problem hiding this comment.
Can we move this up to the other private variables? And also make the _hasFocus private while you are at it? :)
jelbourn
force-pushed
the
bool-property
branch
from
a70e3e5 to
cd04410
Compare
|
@kara rebased and ready for review |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #1289
This removes the custom decorator as it prevents tree-shaking of components that use it. Replaced with a
coerceBooleanPropertyfunction.