chore: bump versions of Angular and devkit betas #13359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't bump to Angular 7 RC because it requires TypeScript 3.1, and devkit/schematics hasn't published a version w/ TypeScript 3.1 yet. Since it's a full dependency there (and not a peer dependency), the version mismatch breaks our schematics. For going to Angular 7 beta.7, we need to now explicitly unset some of the `angularCompilerOptions` in the `tsconfig-test` because they're now inherited. For going to devkit/schematics v6 beta 4, we need to update some imports around the `WorkspaceProject` class. There seem to now be two incompatible versions of this class in the devkit, so we'll need to sort that out soon.
jelbourn
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
devversion
approved these changes
Sep 29, 2018
devversion
added
pr: lgtm
action: merge
Merged
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
We can't bump to Angular 7 RC because it requires TypeScript 3.1, and devkit/schematics hasn't published a version w/ TypeScript 3.1 yet. Since it's a full dependency there (and not a peer dependency), the version mismatch breaks our schematics. For going to Angular 7 beta.7, we need to now explicitly unset some of the `angularCompilerOptions` in the `tsconfig-test` because they're now inherited. For going to devkit/schematics v6 beta 4, we need to update some imports around the `WorkspaceProject` class. There seem to now be two incompatible versions of this class in the devkit, so we'll need to sort that out soon.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't bump to Angular 7 RC because it requires TypeScript 3.1, and
devkit/schematics hasn't published a version w/ TypeScript 3.1 yet.
Since it's a full dependency there (and not a peer dependency), the
version mismatch breaks our schematics.
For going to Angular 7 beta.7, we need to now explicitly unset some of
the
angularCompilerOptionsin thetsconfig-testbecause they're nowinherited.
For going to devkit/schematics v6 beta 4, we need to update some imports
around the
WorkspaceProjectclass. There seem to now be twoincompatible versions of this class in the devkit, so we'll need to sort
that out soon.