Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(tabs): duplicate animation events on some browsers (#13674)" #14015

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Revert "fix(tabs): duplicate animation events on some browsers (#13674)" #14015

merged 1 commit into from
Nov 7, 2018

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 6, 2018

This reverts commit 28e3d36.

This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering. It has to have something to do with the timing change in this PR, but we can't figure out what exactly happened.

cc @crisbeto

@jelbourn
Revert "fix(tabs): duplicate animation events on some browsers (angul…
1e10c28 
…ar#13674)"

This reverts commit 28e3d36.

This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering.
@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Nov 6, 2018
@jelbourn jelbourn requested a review from vivian-hu-zz November 6, 2018 23:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2018
vivian-hu-zz
vivian-hu-zz approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@vivian-hu-zz vivian-hu-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivian-hu-zz vivian-hu-zz added the action: merge The PR is ready for merge by the caretaker label Nov 7, 2018
@vivian-hu-zz vivian-hu-zz merged commit 11c96d6 into angular:master Nov 7, 2018
jelbourn added a commit to jelbourn/components that referenced this pull request Nov 7, 2018
@jelbourn
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
f7d3023 
angular#13674)" (angular#14015)"

This reverts commit 11c96d6.

Turns out the original change wasn't actually the problem. It was angular#13888
instead.
@jelbourn jelbourn mentioned this pull request Nov 7, 2018
Merged
vivian-hu-zz pushed a commit that referenced this pull request Nov 7, 2018
@jelbourn @vivian-hu-zz
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
4508fa1 
#13674)" (#14015)" (#14016)

This reverts commit 11c96d6.

Turns out the original change wasn't actually the problem. It was #13888
instead.
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbourn
Revert "fix(tabs): duplicate animation events on some browsers (#13674)…
ba73d24 
…" (#14015)

This reverts commit 28e3d36.

This change caused a problem in at least one Google app where tabs
inside of a dialog would end up in some kind of frozen animation state
and not rendering.
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@jelbourn
Revert "Revert "fix(tabs): duplicate animation events on some browsers (
5e96e8b 
#13674)" (#14015)" (#14016)

This reverts commit 11c96d6.

Turns out the original change wasn't actually the problem. It was #13888
instead.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vivian-hu-zz vivian-hu-zz vivian-hu-zz approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @vivian-hu-zz @googlebot