fix(material/autocomplete): reopen panel on input click #16020

crisbeto · 2019-05-14T04:50:28Z

Currently if the user clicks an autocomplete to open it, selects an option and then clicks again, the panel won't open, because we use focus and the input was focused already. These changes add an extra click listener so the panel can reopen.

Fixes #15177.

src/material/autocomplete/autocomplete-trigger.ts

crisbeto · 2019-09-09T16:41:27Z

Addressed the feedback @jelbourn.

jelbourn

LGTM

ngbot · 2019-09-12T17:53:29Z

I see that you just added the pr: merge ready label, but the following checks are still failing:
status "ci/circleci: tests_local_browsers" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

patoncrispy · 2020-03-25T17:12:16Z

Is there any chance this will get merged?

wratho · 2020-12-11T17:01:20Z

what is the news on this. Is this something that material agrees with and is just not focusing on or is this antithetical to how material wants this to be handled

jelbourn · 2020-12-14T21:16:01Z

This PR (and any other that get stalled out) was blocked by some number of test failures when we ran it against Google internal CI/presubmit test system. It's in the backlog to investigate, but has been lower priority than other work going on.

DarkSnowy · 2021-11-26T02:54:13Z

Is there a good workaround in the meantime?

Currently if the user clicks an autocomplete to open it, selects an option and then clicks again, the panel won't open, because we use `focus` and the input was focused already. These changes add an extra `click` listener so the panel can reopen. Fixes angular#15177.

Currently if the user clicks an autocomplete to open it, selects an option and then clicks again, the panel won't open, because we use `focus` and the input was focused already. These changes add an extra `click` listener so the panel can reopen. Fixes #15177. (cherry picked from commit 16dea18)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.4/13.2.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.4/13.2.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1325-satin-sash-2022-03-02) [Compare Source](angular/components@13.2.4...13.2.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [9e34a0f69f](angular/components@9e34a0f) | fix | **drag-drop:** error if preview dimensions are accessed too early ([#24498](angular/components#24498)) | | [9be3c46b01](angular/components@9be3c46) | fix | **testing:** TestElement sendKeys method should throw if no keys have been specified ([#18271](angular/components#18271)) | | [8e57a89cba](angular/components@8e57a89) | perf | **overlay:** add event listeners for overlay dispatchers outside of zone ([#24408](angular/components#24408)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [ed2f516401](angular/components@ed2f516) | fix | **autocomplete:** auto-highlighted first option not display correctly if the floating label is disabled ([#14507](angular/components#14507)) | | [502102116e](angular/components@5021021) | fix | **autocomplete:** don't block default arrow keys when using modifiers ([#11987](angular/components#11987)) | | [f31fd3f066](angular/components@f31fd3f) | fix | **autocomplete:** reopen panel on input click ([#16020](angular/components#16020)) | | [5a79042d7d](angular/components@5a79042) | fix | **button-toggle:** use solid border color ([#14253](angular/components#14253)) | | [e2d4eecfcb](angular/components@e2d4eec) | fix | **checkbox:** inconsistent disabled color ([#23083](angular/components#23083)) | | [005ec323de](angular/components@005ec32) | fix | **checkbox:** incorrect text color when placed inside an overlay with a dark theme ([#19054](angular/components#19054)) | | [d7cbd1315f](angular/components@d7cbd13) | fix | **datepicker:** matDatepickerParse error not being added on first invalid value ([#11524](angular/components#11524)) | | [046022f31d](angular/components@046022f) | fix | **datepicker:** use aria-live over cdkAriaLive on period button ([#24398](angular/components#24398)) | | [37f69dbf7e](angular/components@37f69db) | fix | **dialog:** use passed in ComponentFactoryResolver to resolve dialog content ([#17710](angular/components#17710)) | | [2e15f54a9f](angular/components@2e15f54) | fix | **menu:** focus lost if active item is removed ([#14039](angular/components#14039)) | | [ea07fa8e64](angular/components@ea07fa8) | fix | **progress-spinner:** unable to change mode on spinner directive ([#14514](angular/components#14514)) | | [1a498a6a81](angular/components@1a498a6) | fix | **sort:** remove role from header when disabled ([#24477](angular/components#24477)) | | [72019531db](angular/components@7201953) | fix | **tooltip:** don't hide when pointer moves to tooltip ([#24475](angular/components#24475)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [7b85cc077c](angular/components@7b85cc0) | fix | **mdc-button:** density styles being overwritten by structural styles ([#22736](angular/components#22736)) | | [aeb1426e4c](angular/components@aeb1426) | fix | **mdc-chips:** expose avatar harness ([#24499](angular/components#24499)) | #### Special Thanks Andrew Seguin, Artur Androsovych, Jeri Peier, Kristiyan Kostadinov, Paul Gschwendtner, Yousaf Nawaz and Zach Arend  </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1199 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-03-28T00:04:17Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto added the target: patch This PR is targeted for the next patch release label May 14, 2019

crisbeto assigned jelbourn May 14, 2019

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 14, 2019

andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019

jelbourn reviewed Sep 5, 2019

View reviewed changes

src/material/autocomplete/autocomplete-trigger.ts Outdated Show resolved Hide resolved

crisbeto force-pushed the 15177/autocomplete-trigger-click branch from 3a9fdba to 7f79de5 Compare September 9, 2019 16:41

jelbourn approved these changes Sep 12, 2019

View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 12, 2019

crisbeto force-pushed the 15177/autocomplete-trigger-click branch from 7f79de5 to 3d10c25 Compare September 13, 2019 21:16

crisbeto mentioned this pull request Oct 6, 2019

Autocomplete stops showing the List when clicking in the input field after adding a Mat-Chip #17292

Open

mmalerba removed the lgtm label Jul 31, 2020

andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021

crisbeto changed the title ~~fix(autocomplete): reopen panel on input click~~ fix(material/autocomplete): reopen panel on input click Feb 25, 2022

crisbeto force-pushed the 15177/autocomplete-trigger-click branch from 3d10c25 to 2eb9f84 Compare February 25, 2022 09:48

crisbeto removed the needs rebase label Feb 25, 2022

crisbeto force-pushed the 15177/autocomplete-trigger-click branch from 2eb9f84 to 78561ab Compare February 25, 2022 12:01

crisbeto force-pushed the 15177/autocomplete-trigger-click branch from 78561ab to 3f03e7f Compare February 25, 2022 13:20

crisbeto requested a review from a team as a code owner February 25, 2022 13:20

crisbeto merged commit 16dea18 into angular:master Feb 25, 2022

sync-by-unito bot mentioned this pull request Mar 14, 2022

build(deps): bump @angular/cdk from 12.2.4 to 13.2.6 numbersprotocol/capture-lite#1370

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(material/autocomplete): reopen panel on input click #16020

fix(material/autocomplete): reopen panel on input click #16020

crisbeto commented May 14, 2019

crisbeto commented Sep 9, 2019

jelbourn left a comment

ngbot bot commented Sep 12, 2019

patoncrispy commented Mar 25, 2020

wratho commented Dec 11, 2020

jelbourn commented Dec 14, 2020

DarkSnowy commented Nov 26, 2021

angular-automatic-lock-bot bot commented Mar 28, 2022

fix(material/autocomplete): reopen panel on input click #16020

fix(material/autocomplete): reopen panel on input click #16020

Conversation

crisbeto commented May 14, 2019

crisbeto commented Sep 9, 2019

jelbourn left a comment

Choose a reason for hiding this comment

ngbot bot commented Sep 12, 2019

patoncrispy commented Mar 25, 2020

wratho commented Dec 11, 2020

jelbourn commented Dec 14, 2020

DarkSnowy commented Nov 26, 2021

angular-automatic-lock-bot bot commented Mar 28, 2022