Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hover color in table expandable rows example #16146

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Update hover color in table expandable rows example #16146

merged 4 commits into from
Jun 3, 2019

Conversation

wnvko
Copy link
Contributor

@wnvko wnvko commented May 29, 2019

Change hover color to one that looks nice both in white and dark themes.

closes #15735

@wnvko wnvko requested a review from jelbourn as a code owner May 29, 2019 06:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 29, 2019
jelbourn
jelbourn reviewed May 29, 2019
View reviewed changes
src/material-examples/table-expandable-rows/table-expandable-rows-example.css Outdated
@@ -7,7 +7,7 @@ tr.example-detail-row {
}

tr.example-element-row:not(.example-expanded-row):hover {
background: #f5f5f5;
background: #cccccc;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with a contrast ratio calculator and it looks like #777 will actually be the best compromise between light and dark

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking at this. I've changed the color to #777.

@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
jelbourn
jelbourn approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels May 30, 2019
@ngbot
Copy link

ngbot bot commented May 30, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: e2e_tests" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 778fc34 into angular:master Jun 3, 2019
josephperrott pushed a commit that referenced this pull request Jun 10, 2019
@wnvko @josephperrott
docs(table): improve hover color contrast in table-expandable-rows-ex…
d0533d8 
…ample (#16146)
@damyanpetev damyanpetev deleted the mvenkov/fix-hover-color-15735 branch June 11, 2019 08:25
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@wnvko @RudolfFrederiksen
docs(table): improve hover color contrast in table-expandable-rows-ex…
050b758 
…ample (angular#16146)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table-expandable-rows-example text is unreadable on hover with a dark theme
4 participants
@wnvko @jelbourn @googlebot @andrewseguin