feat(select): support disabling #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 6, 2016
… from ControlValueAccessor Implements the `setDisabledState` method from the `ControlValueAccessor` interface in all of the input-related components, in order to support disabling via reactive forms. Note that the `select` component is missing the implementation, however there's a pending PR for it already (angular#1667). Fixes angular#1171.
jelbourn
reviewed
Nov 9, 2016
|
|
||
| // Gradient for showing the dashed line when the input is disabled. | ||
| $md-underline-disabled-background-image: | ||
| linear-gradient(to right, rgba(0, 0, 0, 0.26) 0%, rgba(0, 0, 0, 0.26) 33%, transparent 0%); |
There was a problem hiding this comment.
Add comment saying why you use a linear-gradient like this instead of a border?
| @@ -11,12 +11,12 @@ | |||
| color: md-color($foreground, hint-text); | |||
| border-bottom: 1px solid md-color($foreground, divider); | |||
|
|
|||
| md-select:focus & { | |||
| md-select:focus:not([aria-disabled='true']) & { | |||
There was a problem hiding this comment.
Can we add a class for this instead? Using the aria-disabled makes the selectors somewhat noisy.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 9, 2016
… from ControlValueAccessor Implements the `setDisabledState` method from the `ControlValueAccessor` interface in all of the input-related components, in order to support disabling via reactive forms. Note that the `select` component is missing the implementation, however there's a pending PR for it already (angular#1667). Fixes angular#1171.
|
@jelbourn Comments addressed! |
|
LGTM |
jelbourn
reviewed
Nov 11, 2016
| </md-card> | ||
|
|
||
| <md-card> | ||
| <md-select placeholder="Drink" [(ngModel)]="currentDrink" [required]="isRequired" [disabled]="isDisabled" |
There was a problem hiding this comment.
currentDrink needs to be defined in the class.
(failing google presubmit)
kara
force-pushed
the
select-disabled
branch
from
1ae0a35
to
4fa4aa6
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 19, 2016
… from ControlValueAccessor Implements the `setDisabledState` method from the `ControlValueAccessor` interface in all of the input-related components, in order to support disabling via reactive forms. Note that the `select` component is missing the implementation, however there's a pending PR for it already (angular#1667). Fixes angular#1171.
tinayuangao
pushed a commit
that referenced
this pull request
Nov 29, 2016
… from ControlValueAccessor (#1750) Implements the `setDisabledState` method from the `ControlValueAccessor` interface in all of the input-related components, in order to support disabling via reactive forms. Note that the `select` component is missing the implementation, however there's a pending PR for it already (#1667). Fixes #1171.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for disabling the select and its options. Needs to be rebased once #1657 and #1655 go in.
r: @jelbourn