fix(radio): Fix radio group behavior when radio button value changed #1735
Conversation
googlebot
added
the
cla: yes
| @@ -274,6 +274,29 @@ describe('MdRadio', () => { | |||
| expect(groupInstance.value).toBe('water'); | |||
| expect(changeSpy).not.toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| it('should update checked status if changed value to radio group\'s value', () => { | |||
There was a problem hiding this comment.
Instead of escaping the ', you can use a different type of quote for the string (usually backtick)
| } | ||
| } | ||
|
|
||
| _checkSelectedButton() { |
There was a problem hiding this comment.
How about _checkSelectedRadioButton ?
| radio.checked = this.value == radio.value; | ||
| if (radio.checked) { | ||
| this._selected = radio; | ||
| } |
There was a problem hiding this comment.
Are we losing anything by no longer going through the setter for selected here?
There was a problem hiding this comment.
The selected() does 3 things: update _selected (which is done); update value (_updateSelectedRadioFromValue is always called from value change) ; check selected radio button (we get the _selected value from checked radio buttons, and checked is set on line 190).
tinayuangao
force-pushed
the
checkbox-event
branch
from
5dd2965
to
32c0c2d
Compare
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When radio button value changed, if the new value matches group's value, the button should be checked.
Closes #1152
R: @jelbourn