Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snackbar): add onAction to snackbar ref #1826

Merged
merged 2 commits into from
Nov 15, 2016
Merged

feat(snackbar): add onAction to snackbar ref #1826

merged 2 commits into from
Nov 15, 2016

Conversation

josephperrott
Copy link
Member

For #1616

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2016
jelbourn
jelbourn reviewed Nov 11, 2016
View reviewed changes
src/lib/snack-bar/snack-bar-ref.ts
@@ -38,8 +43,21 @@ export class MdSnackBarRef<T> {
}
}

/** Marks the snackbar action clicked. */
action(): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark this as internal (just an underscore prefix without private or @internal)? I don't think users should be calling it on their own.

src/lib/snack-bar/snack-bar.spec.ts
actionObservableCompleted = true;
});

snackBarRef.action();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling this directly, could you grab the action button element and call .click() on it?

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 12, 2016
@kara kara merged commit a40cae9 into angular:master Nov 15, 2016
@willshowell willshowell mentioned this pull request Jul 10, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @jelbourn @kara @googlebot