Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): Support fallback positioning on menu trigger. #1829

Closed
wants to merge 1 commit into from

Conversation

trshafer
Copy link
Contributor

This ensures that the menu will do the best attempt at showing instead of rendering off screen.

This ensures that the menu will do the best attempt at showing
instead of rendering off screen.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 17, 2016

I believe this was already addressed in #1761. @kara can you confirm?

(FYI, be sure to let us know if you plan on doing work to something under active development like menu or select so we can avoid conflicts)

@trshafer
Copy link
Contributor Author

The other PR looks good. Thanks for merging it in.

@trshafer trshafer closed this Nov 17, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants