fix(select): add aria-owns property #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 16, 2016
| * Option IDs need to be unique across components, so this counter exists outside of | ||
| * the component definition. | ||
| */ | ||
| var _selectOptionCounter = 0; |
There was a problem hiding this comment.
How about?
/** Unique ID counter for md-option. */
let _uniqueIdCounter = 0;| @@ -291,6 +300,11 @@ export class MdSelect implements AfterContentInit, ControlValueAccessor, OnDestr | |||
| this._subscriptions = []; | |||
| } | |||
|
|
|||
| /** Records option IDs to pass to the aria-owns property. */ | |||
| private _setOptionIds() { | |||
| this._optionIds = this.options.map((option) => option.id).join(' '); | |||
There was a problem hiding this comment.
nit: don't need parens around option
| expect(selects[0].nativeElement.getAttribute('aria-owns')) | ||
| .not.toEqual(selects[1].nativeElement.getAttribute('aria-owns'), | ||
| `Expected select components to have unique option IDs in aria-owns attr.`); | ||
| }); |
There was a problem hiding this comment.
Need a test where you assert that the aria-owns contains each of the options's IDs. Something like
expect(ariaOwns).toContain(options[0].id);
expect(ariaOwns).toContain(options[1].id);
...
|
@jelbourn Comments addressed! |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r: @jelbourn