feat(list): add keyboard navigation #1999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds the ability to switch focus between list items using the up/down keys. * Splits up the various list-related components into separate files. Fixes angular#941.
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 28, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate. Relates to angular#1999.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 28, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate. Relates to angular#1999.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 28, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate. Relates to angular#1999.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 29, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate. Relates to angular#1999.
tinayuangao
pushed a commit
that referenced
this pull request
Dec 1, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate. Relates to #1999.
|
@crisbeto I double-checked the w3c docs for ths, and I think we don't want to make this change. The keyboard interaction would come into play when we implement |
|
I see. I wasn't aware that |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #941.