fix(select): only animate placeholder when no selection #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
force-pushed
the
label-animation
branch
3 times, most recently
from
a00d8c8
to
e2c2c09
Compare
jelbourn
reviewed
Dec 2, 2016
| padding: 0 2px; | ||
| transform-origin: left top; | ||
|
|
||
| &.md-floating-placeholder { |
There was a problem hiding this comment.
Need comment explaining why this is duplicated from the animation code.
|
@jelbourn Added the comment! |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
tinayuangao
reviewed
Dec 2, 2016
| @@ -1,5 +1,6 @@ | |||
| <div class="md-select-trigger" overlay-origin (click)="toggle()" #origin="overlayOrigin" #trigger> | |||
| <span class="md-select-placeholder" [@transformPlaceholder]="_getPlaceholderState()"> {{ placeholder }} </span> | |||
| <span class="md-select-placeholder" [class.md-floating-placeholder]="this._selected" | |||
There was a problem hiding this comment.
this._selected is private. Better to use this.selected.
There was a problem hiding this comment.
Whoops! You're absolutely right, it should be selected.
|
@tinayuangao Should be corrected now. Thanks for catching! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses CSS to float the placeholder when the value is set programmatically so no animation plays. Will only play animation if the panel is opening or closing without a selection.
r: @jelbourn