Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autocomplete): add autocomplete scaffold #2092

Merged
merged 1 commit into from
Dec 7, 2016

Conversation

kara
Copy link
Contributor

@kara kara commented Dec 6, 2016

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2016
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from selectors


@Component({
moduleId: module.id,
selector: 'md-autocomplete',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add mat-autocomplete and add the appropriate selectors under core/compatibility

@kara kara added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2016
@kara
Copy link
Contributor Author

kara commented Dec 7, 2016

@jelbourn Good catch! Fixed.

@mmalerba mmalerba merged commit 4c49f5f into angular:master Dec 7, 2016
josephperrott pushed a commit to josephperrott/components that referenced this pull request Dec 8, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants