Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theming): provide a content wrapper attribute #2170

Merged
merged 1 commit into from
Jan 18, 2017
Merged

feat(theming): provide a content wrapper attribute #2170

merged 1 commit into from
Jan 18, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 11, 2016 •
edited
Loading

Adds the md-app-background class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is md-sidenav-container and it's not something that necessarily everybody uses.

Fixes #1938.
Fixes #2106.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2016
@jelbourn
Copy link
Member

jelbourn commented Dec 14, 2016 •
edited
Loading

I like the idea, but not sure about the name. The name should communicate exactly what it does, so I'm thinking maybe md-main-content-background or maybe just md-app-background. Perhaps also making it a class instead of an attr. Thoughts?

@crisbeto
Copy link
Member Author

Regarding the name, I went with "wrapper" in case we wanted to use it for something else in the future (like md-content in Material 1). As for the attribute, it's in case we want to turn it into a directive afterwards.

@crisbeto crisbeto force-pushed the 1938/theme-background-element branch from 1eadcca to 5f0362b Compare December 20, 2016 10:50
@crisbeto
Copy link
Member Author

Renamed it to md-app-background and switched it over to a class @jelbourn.

@crisbeto crisbeto force-pushed the 1938/theme-background-element branch from 5f0362b to ec255d5 Compare December 30, 2016 12:39
@crisbeto
feat(theming): provide a content wrapper attribute
75e9f18 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
@crisbeto crisbeto force-pushed the 1938/theme-background-element branch from ec255d5 to 75e9f18 Compare January 12, 2017 18:35
jelbourn
jelbourn approved these changes Jan 14, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 14, 2017
@mmalerba mmalerba merged commit 4bf4b87 into angular:master Jan 18, 2017
kara pushed a commit to kara/material2 that referenced this pull request Jan 20, 2017
@crisbeto @kara
feat(theming): provide a content wrapper attribute (angular#2170)
4329379 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<md-input> placeholders are not working on the pink-bluegrey theme. Container for non-sidenav-layouts
4 participants
@crisbeto @jelbourn @googlebot @mmalerba