Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/text-field): autosize text areas using the placeholder #22197

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(cdk/text-field): autosize text areas using the placeholder #22197

merged 1 commit into from
Mar 19, 2021

Conversation

jermowery
Copy link
Contributor

Fixes a bug with CdkTextareaAutosize where the textarea would not be autosized when using long placeholders

Fixes #22042

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 11, 2021
@jermowery
Copy link
Contributor Author

Had to also adjust the input tests

Fixes a bug with CdkTextareaAutosize where the textarea would not be autosized when using long placeholders

Fixes #22042

Cache the height with the placeholder

do calculation better

fix comment

Stop caching the placeholder because I can't make the caching approach work with view-engine

go back to the caching approach

Account for the input tests

fix lint error
@jermowery jermowery requested a review from a team as a code owner March 12, 2021 19:15
@jelbourn jelbourn added target: major This PR is targeted for the next major release area: cdk/text-field labels Mar 12, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 12, 2021
@jermowery
Copy link
Contributor Author

Sadly this break g3 because the value is changed on the textarea. I think I will have to abandon this completely as I will be unavailable to look at this for a week and we have other high priority things to deal with right now

@andrewseguin andrewseguin merged commit 476a90b into angular:master Mar 19, 2021
andrewseguin added a commit to andrewseguin/components that referenced this pull request Mar 19, 2021
mmalerba added a commit to mmalerba/components that referenced this pull request Mar 22, 2021
mmalerba added a commit to mmalerba/components that referenced this pull request Mar 31, 2021
annieyw pushed a commit that referenced this pull request Apr 2, 2021
* fix(cdk/text-field): autosize text areas using the placeholder

Roll-forward w/ fix for #22197

This reverts commit 4316787.

* fixup! fix(cdk/text-field): autosize text areas using the placeholder

* fixup! fix(cdk/text-field): autosize text areas using the placeholder

* fixup! fix(cdk/text-field): autosize text areas using the placeholder

* fixup! fix(cdk/text-field): autosize text areas using the placeholder
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/text-field cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cdkTextareaAutosize): cdkTextareaAutosize does not resize when the placeholder or label is long
3 participants