feat(elevation): Add elevation core styles #222
Conversation
googlebot
added
the
cla: yes
| // `md-elevation-z$zValue` where `$zValue` correspond to the z-space in which the element is | ||
| // elevated to. | ||
| @for $zValue from 0 through 24 { | ||
| .md-elevation-z#{$zValue} { |
There was a problem hiding this comment.
In Material 1, we deprecated the z suffix, and decided to use dp. Is here another background?
There was a problem hiding this comment.
I talk about this in the design doc. Essentially, z-space makes more sense to speak about elevation on the web platform. dp works great for a design spec but possibly isn't as semantic for web developers.
There was a problem hiding this comment.
I agree with you. dp always remembers me on a native app. Device Specific unit etc. I was just curious, because we deprecated those in Material 1.
| * https://goo.gl/Kq0k9Z. | ||
| */ | ||
|
|
||
| $_umbra-color: rgba(black, 0.2); |
There was a problem hiding this comment.
Are you able to comment on what each of umbra, penumbra and ambient mean?
|
@traviskaufman The CI is failing due to the ``` characters in elevation.scss, which the |
This commit replaces `_shadows.scss` within `src/core/styles` with `_elevation.scss`, according to the proposed design outlined [here](https://goo.gl/Kq0k9Z). All components that were dependent on the old shadows have been modified to use elevation. Note however that none of the values in those old components have been changed; it's simply a to the new API. Part of angular#48.
traviskaufman
force-pushed
the
feat-md-elevation
branch
from
99ed7ff
to
3899a52
Compare
|
@jelbourn all changes made and CI issue fixed I moved the exported CSS classes into |
| @@ -0,0 +1,12 @@ | |||
| // Core styles that can be used to apply material design treatments to any element. | |||
There was a problem hiding this comment.
This is good for now, but FYI I'm going to move it to src/main.scss once my outstanding PR lands.
|
LGTM Would be good if one of @kara / @hansl / @robertmesserle also took a look |
|
👍 this LGTM. |
|
At risk of getting the famous "we haven't done theming yet" response, is there a way to use |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit replaces
_shadows.scsswithinsrc/core/styleswith_elevation.scss, according to the proposed design outlinedhere. All components that were dependent on the
old shadows have been modified to use elevation. Note however that none
of the values in those old components have been changed; it's simply a
to the new API.
Part of #48.