fix(material-experimental/mdc-core): add app background color #22992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
commented
Jun 16, 2021
| // inside of a `mat-sidenav-container`. Note that we need to exclude the ampersand | ||
| // selector in case the mixin is included at the top level. | ||
| .mat-mdc-app-background#{if(&, ', &.mat-mdc-app-background', '')} { | ||
| $background: map.get($color, background); |
There was a problem hiding this comment.
Note that here I'm going through our own theming system, rather that MDC's, because I couldn't figure out how to generate the same colors with MDC. The only thing remotely close is the filled appearance of the form field, but its background color on a dark theme was a bit lighter than what we have.
andrewseguin
removed
the
cla: yes
crisbeto
force-pushed
the
mdc-app-background
branch
from
205a374 to
18f5784
Compare
Adds a `mat-mdc-app-background` utility class similar to `mat-app-background`.
crisbeto
force-pushed
the
mdc-app-background
branch
from
18f5784 to
94e3840
Compare
devversion
approved these changes
Mar 16, 2022
crisbeto
added a commit
that referenced
this pull request
Mar 16, 2022
Adds a `mat-mdc-app-background` utility class similar to `mat-app-background`. (cherry picked from commit 6982ca7)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 23, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.6/13.3.0) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.6/13.3.0) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1330-aluminum-armadillo-2022-03-16) [Compare Source](angular/components@13.2.6...13.3.0) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [e4c64dd56](angular/components@e4c64dd) | fix | **drag-drop:** only block dragstart event on event targets ([#​24581](angular/components#24581)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [33d07df95](angular/components@33d07df) | fix | **badge:** ensure overflow visible ([#​24602](angular/components#24602)) | | [dfef17351](angular/components@dfef173) | fix | **datepicker:** fix Voiceover losing focus on PageDown ([#​24399](angular/components#24399)) | | [1703b83ae](angular/components@1703b83) | fix | **datepicker:** use cdk-visually-hidden on calendar header ([#​24523](angular/components#24523)) | | [41320d07e](angular/components@41320d0) | fix | **tabs:** avoid timeouts in background tabs ([#​24000](angular/components#24000)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [097ec0d11](angular/components@097ec0d) | fix | **mdc-core:** add app background color ([#​22992](angular/components#22992)) | | [15a0676d5](angular/components@15a0676) | fix | **mdc-radio:** add hover indication ([#​24595](angular/components#24595)) | #### Special Thanks Andrew Seguin, Kristiyan Kostadinov, Paul Gschwendtner and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1229 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…r#22992) Adds a `mat-mdc-app-background` utility class similar to `mat-app-background`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
mat-mdc-app-backgroundutility class similar tomat-app-background.