Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable public API verification on the MDC slider #23053

Merged
merged 1 commit into from
Jun 25, 2021
Merged

build: enable public API verification on the MDC slider #23053

merged 1 commit into from
Jun 25, 2021

Conversation

crisbeto
Copy link
Member

We had disabled the public API check on the MDC slider while it was being rewritten, but now it can be re-enabled.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jun 23, 2021
@crisbeto crisbeto requested a review from wagnermaciel June 23, 2021 18:49
@crisbeto crisbeto requested a review from a team as a code owner June 23, 2021 18:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 23, 2021
josephperrott
josephperrott approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 23, 2021
@crisbeto
build: enable public API verification on the MDC slider
640736e 
We had disabled the public API check on the MDC slider while it was being rewritten, but now it can be re-enabled.
@crisbeto crisbeto force-pushed the mdc-slider-public-api branch from 6a5e0d0 to 640736e Compare June 24, 2021 15:25
@amysorto amysorto merged commit d6b6b5a into angular:master Jun 25, 2021
amysorto pushed a commit that referenced this pull request Jun 25, 2021
@crisbeto @amysorto
build: enable public API verification on the MDC slider (#23053)
4ea8271 
We had disabled the public API check on the MDC slider while it was being rewritten, but now it can be re-enabled.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@devversion devversion devversion approved these changes

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @josephperrott @amysorto