fix(button-toggle): conflict with radio component #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Prevents the button toggle from conflicting with radio buttons on the same page. This was because both components were using the same pattern to generate unique `name` attributes. Fixes angular#2274.
crisbeto
force-pushed
the
2274/button-toggle-conflict
branch
from
99d2563
to
c9508f8
Compare
jelbourn
added
pr: lgtm
action: merge
kara
pushed a commit
to kara/material2
that referenced
this pull request
Jan 20, 2017
Prevents the button toggle from conflicting with radio buttons on the same page. This was because both components were using the same pattern to generate unique `name` attributes. Fixes angular#2274.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the button toggle from conflicting with radio buttons on the same page. This was because both components were using the same pattern to generate unique
nameattributes.Fixes #2274.